mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Lundell <linux@lundell-bros.com>
To: linux-kernel@vger.kernel.org
Subject: NMI watchdog, die(), & console_loglevel
Date: Wed, 31 Jul 2002 09:15:07 -0700	[thread overview]
Message-ID: <p05111a0bb96dbbf51858@[207.213.214.37]> (raw)
In-Reply-To: <1028125599.7886.68.camel@irongate.swansea.linux.org.uk>

The i386 NMI watchdog handler prints a message, sets console_loglevel 
to 0 (no output to console), and then kills the current task 
(arch/i386/kernel/nmi.c:nmi_watchdog_tick()); it then leaves the 
console turned off.

die(), on the other hand, starts out by setting console_loglevel to 
15 (print everything), and leaves it there.

Neither behavior seems particularly appropriate, and taken together 
they seem at least inconsistent. What's the justification, if any, 
and wouldn't it be better to leave console_loglevel alone and set an 
appropriate message loglevel? (Not that I'd claim for an instant that 
message loglevels are used consistently; have a look at the various 
applications of KERN_EMERG, for example.)
-- 
/Jonathan Lundell.

  parent reply	other threads:[~2002-07-31 16:11 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-31 11:01 Linux 2.4.19ac3rc3 on IBM x330/x340 SMP - "ps" time skew David Luyer
2002-07-31 13:28 ` Alan Cox
2002-07-31 12:59   ` David Luyer
2002-07-31 14:26     ` Alan Cox
2002-07-31 13:18       ` David Luyer
2002-07-31 13:31       ` Dana Lacoste
2002-07-31 13:38         ` David Luyer
2002-07-31 15:04           ` Alan Cox
2002-07-31 13:57             ` David Luyer
2002-07-31 16:15       ` Jonathan Lundell [this message]
2002-07-31 19:14       ` Albert D. Cahalan
2002-08-01  0:37         ` Alan Cox
2002-07-31 23:49           ` Dave Jones
2002-08-01  1:30             ` Alan Cox
2002-08-01  0:19               ` Dave Jones
2002-07-31 23:42     ` Lincoln Dale
2002-08-01  1:33       ` Albert D. Cahalan
2002-08-01  3:34         ` Martin J. Bligh
2002-08-01 14:16           ` Alan Cox
2002-08-01  8:49         ` Benjamin Herrenschmidt
2002-08-01 11:40         ` Lincoln Dale
2002-08-01 18:26           ` Albert D. Cahalan
2002-08-01 14:15         ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='p05111a0bb96dbbf51858@[207.213.214.37]' \
    --to=linux@lundell-bros.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®