mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joseph Krahn <joseph.krahn@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: parport_pc.c and parport_serial.c need improvements
Date: Fri, 23 Apr 2010 12:33:06 -0400	[thread overview]
Message-ID: <p2pff6de6f21004230933t6fdeb985jeca51a550e3dbc5b@mail.gmail.com> (raw)

In 2005, Russel King cleaned up parport_serial.c to remove redundancy
with 8250_pci.c (http://lwn.net/Articles/141484/). In working on
fixing the ITE-887x driver, I realized that there is still a lot of
redundancy with parport_pc.c. Furthermore, parport_pc seems to have
some deficiencies. It does not call pci_disable_device() when
unloading the driver (as pci.txt says it should) and seems to be
missing power suspend/resume code.

Also, the Super IO code looks rather messy. To work with
parport_serial, struct pci_parport_data could include a device_private
pointer to attach  the serial-port data. The SuperIO code could use
this to attach struct superio_struct. Maybe the SuperIO code should be
in a separate module (i.e. parport_superio) that depends on
parport_pc, similar to parport_serial. In any case, it would be nice
to see more comments on why the SuperIO code is designed as it is.

 OTOH, maybe parport hardware is simple enough that it is not worth
messing with the code as long as it seems to work OK.

Thanks,
Joe Krahn

             reply	other threads:[~2010-04-23 16:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-23 16:33 Joseph Krahn [this message]
2010-04-26 22:10 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p2pff6de6f21004230933t6fdeb985jeca51a550e3dbc5b@mail.gmail.com \
    --to=joseph.krahn@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®