From: Andi Kleen <ak@suse.de>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: Andrew Morton <akpm@osdl.org>,
ebiederm@xmission.com, pj@sgi.com,
saito.tadashi@soft.fujitsu.com, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] ps command race fix take2 [3/4] profile fix
Date: 22 Aug 2006 13:08:49 +0200 [thread overview]
Message-ID: <p737j1181tq.fsf@verdi.suse.de> (raw)
In-Reply-To: <20060822174152.7105aa33.kamezawa.hiroyu@jp.fujitsu.com>
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> writes:
> ===================================================================
> --- linux-2.6.18-rc4.orig/include/linux/sched.h
> +++ linux-2.6.18-rc4/include/linux/sched.h
> @@ -808,6 +808,10 @@ struct task_struct {
> struct list_head ptrace_children;
> struct list_head ptrace_list;
>
> +#if defined(CONFIG_OPROFILE) || defined(CONFIG_OPROFILE_MODULE)
> + struct list_head dead_tasks;
> +#endif
Sorry I think this needs a cleaner solution without ifdef. Why can't it use
the token list? Or some other list head that's unused then.
Otherwise I would think it it better to use a separate list object to
maintain this list in oprofile.
-Andi
next prev parent reply other threads:[~2006-08-22 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 8:41 KAMEZAWA Hiroyuki
2006-08-22 11:08 ` Andi Kleen [this message]
2006-08-22 11:28 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p737j1181tq.fsf@verdi.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pj@sgi.com \
--cc=saito.tadashi@soft.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®