mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Fernando Luis Vazquez Cao <fernando@intellilink.co.jp>
Cc: linux-kernel@vger.kernel.org, fastboot@lists.osdl.org
Subject: Re: [PATCH 1/4] stack overflow safe kdump (i386) - safe_smp_processor_id
Date: 28 Nov 2005 16:07:40 -0700	[thread overview]
Message-ID: <p738xv8id6r.fsf@verdi.suse.de> (raw)
In-Reply-To: <1133200833.2425.100.camel@localhost.localdomain>

Fernando Luis Vazquez Cao <fernando@intellilink.co.jp> writes:
> 
> To circumvent this problem I suggest implementing
> "safe_smp_processor_id()" (it already exists on x86_64) for i386 and
> IA64 and use it as a replacement to smp_processor_id in the reboot path
> to the dump capture kernel. This is a possible implementation for i386.

It's not fully safe, because a SMP kernel might run on a 32bit
system without APIC. Then hard_smp_processor_id() would fault. 
(this cannot happen on x86-64)

You probably need to check one of the globals set by apic.c
when its disabled.

-Andi

  reply	other threads:[~2005-11-28 18:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-28 18:00 Fernando Luis Vazquez Cao
2005-11-28 23:07 ` Andi Kleen [this message]
2005-11-29  4:16   ` [Fastboot] " Eric W. Biederman
2005-11-30  7:32     ` Fernando Luis Vazquez Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p738xv8id6r.fsf@verdi.suse.de \
    --to=ak@suse.de \
    --cc=fastboot@lists.osdl.org \
    --cc=fernando@intellilink.co.jp \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome