mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, schwidefsky@de.ibm.com
Subject: Re: [patch] cputime: introduce cputime.
Date: 28 Oct 2004 11:36:51 +0200	[thread overview]
Message-ID: <p738y9r18wc.fsf@verdi.suse.de> (raw)
In-Reply-To: <20041028021317.48a6d0c2.akpm@osdl.org.suse.lists.linux.kernel>

Andrew Morton <akpm@osdl.org> writes:

> Martin Schwidefsky <schwidefsky@de.ibm.com> wrote:
> >
> > > - kernel threads may have null p->signal
> >  > - remove some deoptimising inlines
> > 
> >  Does it work with these two changes ?
> 
> Well it doesn't crash ;)
> 
> It compiles OK on a bunch of architectures, bloats the kernel by 2k and
> various system monitoring tools emit sensible-looking numbers.  What should
> I be looking for?

2K sounds definitely wrong. Martin's patch should be ideally a nop
for architectures that use asm-generic/cputime.h 

-Andi

       reply	other threads:[~2004-10-28  9:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20041027224805.31f5747b.akpm@osdl.org.suse.lists.linux.kernel>
     [not found] ` <OF35D2677F.494347CD-ON42256F3B.002DDBE5-42256F3B.002F22AE@de.ibm.com.suse.lists.linux.kernel>
     [not found]   ` <20041028021317.48a6d0c2.akpm@osdl.org.suse.lists.linux.kernel>
2004-10-28  9:36     ` Andi Kleen [this message]
2004-10-27 14:21 Martin Schwidefsky
2004-10-27 14:56 ` Rik van Riel
2004-10-28  5:48 ` Andrew Morton
     [not found]   ` <OF35D2677F.494347CD-ON42256F3B.002DDBE5-42256F3B.002F22AE@de.ibm.com>
2004-10-28  9:13     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p738y9r18wc.fsf@verdi.suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®