From: Andi Kleen <ak@suse.de>
To: John Levon <levon@movementarian.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] OProfile: correct CPU type for x86-64
Date: 31 Aug 2003 22:25:08 +0200 [thread overview]
Message-ID: <p73ad9po9qz.fsf@oldwotan.suse.de> (raw)
In-Reply-To: <20030831191937.GA32426@compsoc.man.ac.uk.suse.lists.linux.kernel>
John Levon <levon@movementarian.org> writes:
> + break;
> +#if defined(CONFIG_X86_64)
> + case 0xf:
> + model = &op_athlon_spec;
> + nmi_ops.cpu_type = "x86-64/hammer";
> + break;
> +#endif /* CONFIG_X86_64 */
The ifdef is not needed. The case is valid for i386 too, when running
an Opteron with an 32bit kernel. In that case you also want the user tools
to select the Opteron events.
-Andi
next parent reply other threads:[~2003-08-31 20:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20030831191937.GA32426@compsoc.man.ac.uk.suse.lists.linux.kernel>
2003-08-31 20:25 ` Andi Kleen [this message]
2003-08-31 19:19 John Levon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73ad9po9qz.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=levon@movementarian.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®