From: Andi Kleen <ak@suse.de>
To: Dave Peterson <dsp@llnl.gov>
Cc: linux-kernel@vger.kernel.org, riel@surriel.com, akpm@osdl.org
Subject: Re: [PATCH 1/2] mm: serialize OOM kill operations
Date: 26 Apr 2006 06:46:43 +0200 [thread overview]
Message-ID: <p73k69d7xl8.fsf@bragg.suse.de> (raw)
In-Reply-To: <200604251701.31899.dsp@llnl.gov>
Dave Peterson <dsp@llnl.gov> writes:
>
> Index: git7-oom/include/linux/sched.h
> ===================================================================
> --- git7-oom.orig/include/linux/sched.h 2006-04-25 16:19:40.000000000 -0700
> +++ git7-oom/include/linux/sched.h 2006-04-25 16:21:48.000000000 -0700
> @@ -350,6 +350,8 @@ struct mm_struct {
> /* aio bits */
> rwlock_t ioctx_list_lock;
> struct kioctx *ioctx_list;
> +
> + int oom_notify;
That wastes 4 bytes for a single bit. Please put a flag into some of the existing
flag bitmaps instead.
-Andi
next prev parent reply other threads:[~2006-04-26 4:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 0:01 Dave Peterson
2006-04-26 4:10 ` Nick Piggin
2006-04-26 17:14 ` Dave Peterson
2006-04-27 3:33 ` Nick Piggin
2006-04-27 16:56 ` Dave Peterson
2006-04-28 5:00 ` Nick Piggin
2006-04-28 5:05 ` Nick Piggin
2006-04-26 4:46 ` Andi Kleen [this message]
2006-04-26 17:15 ` Dave Peterson
2006-04-26 18:05 ` Andi Kleen
2006-04-26 18:29 ` Dave Peterson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73k69d7xl8.fsf@bragg.suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=dsp@llnl.gov \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@surriel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome