From: Andi Kleen <ak@suse.de>
To: "Nakajima, Jun" <jun.nakajima@intel.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Mallick, Asit K" <asit.k.mallick@intel.com>,
"Saxena, Sunil" <sunil.saxena@intel.com>
Subject: Re: [PATCH] fixes for building kernel using Intel compiler
Date: 19 Oct 2002 02:07:41 +0200 [thread overview]
Message-ID: <p73u1jjnvea.fsf@oldwotan.suse.de> (raw)
In-Reply-To: "Nakajima, Jun"'s message of "19 Oct 2002 01:53:00 +0200"
"Nakajima, Jun" <jun.nakajima@intel.com> writes:
> -asmlinkage int sys_iopl(unsigned long unused)
> +asmlinkage int sys_iopl(struct pt_regs * regs)
> {
> - struct pt_regs * regs = (struct pt_regs *) &unused;
The change is wrong. The pt_regs are passed by value on the stack, not by reference.
>
> -/* Enable FXSR and company _before_ testing for FP problems. */
> - /*
> - * Verify that the FXSAVE/FXRSTOR data will be 16-byte aligned.
> - */
> - if (offsetof(struct task_struct, thread.i387.fxsave) & 15) {
> - extern void __buggy_fxsr_alignment(void);
> - __buggy_fxsr_alignment();
> - }
Why does that not work? IMHO it is legal ISO-C
-Andi
next parent reply other threads:[~2002-10-19 0:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <F2DBA543B89AD51184B600508B68D4000E6ADE5B@fmsmsx103.fm.intel.com.suse.lists.linux.kernel>
2002-10-19 0:07 ` Andi Kleen [this message]
2002-10-19 0:15 ` David S. Miller
2002-10-19 0:25 ` Andi Kleen
[not found] <A9EA4AD6F6B9D511BBED00508B66C69A04B37747@fmsmsx111.fm.intel.com>
2002-10-22 22:41 ` Suresh Siddha
2002-10-21 18:28 Ulrich Weigand
-- strict thread matches above, loose matches on Subject: below --
2002-10-19 2:17 Nakajima, Jun
2002-10-19 2:29 ` Andi Kleen
2002-10-21 9:21 ` Pavel Machek
2002-10-19 1:16 Nakajima, Jun
2002-10-19 0:45 Nakajima, Jun
2002-10-19 1:02 ` Andi Kleen
2002-10-18 23:48 Nakajima, Jun
2002-10-19 0:08 ` Greg KH
2002-10-21 12:48 ` Alan Cox
2002-10-21 15:56 ` Nakajima, Jun
2002-10-21 17:06 ` Brian Gerst
2002-10-22 6:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=p73u1jjnvea.fsf@oldwotan.suse.de \
--to=ak@suse.de \
--cc=asit.k.mallick@intel.com \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sunil.saxena@intel.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®