mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: vda <vda@port.imtp.ilyichevsk.odessa.ua>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Asm style
Date: 21 Nov 2001 22:23:25 +0100	[thread overview]
Message-ID: <p73wv0jx1gy.fsf@amdsim2.suse.de> (raw)
In-Reply-To: <01112123070300.05447@manta.suse.lists.linux.kernel>
In-Reply-To: vda's message of "21 Nov 2001 22:13:40 +0100"

vda <vda@port.imtp.ilyichevsk.odessa.ua> writes:

> I'm using GCC 3.0.1 and seeing "multi-line literals are deprecated".
> Since a patch is necessary for that (and someone submitted it already)

The best patch for this IMHO would be to just remove the stupid warning
from gcc. It's obvious that whoever added it has never used gcc inline
assembly.

If they want to remove multi-line strings they need to supply a way to
write inline assembly without strings first. Both solutions below
are very error prone and ugly.

Failing that:

> 	asm(
> 	"	cmd	r,r\n"
> 	"lbl:	cmd	r,r\n"
> 	"	cmd	r,r\n"

Is bearable with some pains.


> #define NL "\n"
> 	asm(
> 	"	cmd	r,r" NL
> 	"lbl:	cmd	r,r" NL

Is also bearable, but needs agreement (needs a central #define) 

-Andi


       reply	other threads:[~2001-11-21 21:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <01112123070300.05447@manta.suse.lists.linux.kernel>
2001-11-21 21:23 ` Andi Kleen [this message]
2001-11-21 23:07 vda
2001-11-21 21:21 ` Ben Collins
2001-11-22 12:43 Giacomo Catenazzi
     [not found] ` <fa.d6k3juv.16q3on@ifi.uio.no>
     [not found]   ` <fa.cbkkrrv.m72ejr@ifi.uio.no>
2001-11-22  9:27     ` ncw
     [not found] <fa.derh1nv.1h0ai0b@ifi.uio.no>
     [not found] ` <fa.njuqm5v.100c5ak@ifi.uio.no>
2001-11-22 14:29   ` Giacomo Catenazzi
2001-11-22 11:31     ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=p73wv0jx1gy.fsf@amdsim2.suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vda@port.imtp.ilyichevsk.odessa.ua \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®