mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Suparna Bhattacharya" <suparna@sparklet.in.ibm.com>
To: undisclosed-recipients:;
Subject: Re: [PATCH] 2.5.44: lkcd (7/9): dump configuration
Date: Tue, 22 Oct 2002 14:18:14 +0530	[thread overview]
Message-ID: <pan.2002.10.22.14.18.14.702192.1573@sparklet.in.ibm.com> (raw)
In-Reply-To: <20021021165240.A14993@sgi.com>

On Mon, 21 Oct 2002 19:13:16 +0530, Christoph Hellwig wrote:

>> +tristate 'Crash dump support' CONFIG_CRASH_DUMP
> 
> I"m very unhappy with this beeing a tristate.  We have the following
> things depend on it either builtin or modular:
> 
> (1) build Kerntypes
> (2) do not send smp_stop_cpu
> 
> and the following goes into dump.o:
> 
> (3) dump_base.c
> (4) dump_<arch>.c
> 
> Of those (2) should be replaced by a dump_in_progress check so that we
> poweroff even with dumping enabled, but not in progress.

The problem here is that dump_in_progress is set by the dump 
execution code which is invoked a little after this, and only
stays enabled as long as that function executes. Maybe what
you meant here is not dump_in_progress but something more like
dump_okay (which is currently a static in dump drivers code), 
or a check if the dump function is set, indicating that 
things are setup so that a dump would be taken ?

Regards
Suparna

> 
> The question is whether we should make (1) unconditional either or make
> it a separate bool (CONFIG_KERNELTYPES) so that that dump.o could be
> load into any such kernel.  But imho CONFIG_CRASH_DUMP should just
> become a bool - this way dump_<arch>.c could be moved into
> arch/<arch>/kernel and a lot of exports could be remove.
> 
> It's not much code either and the actual dump drivers stay modular.
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel"
> in the body of a message to majordomo@vger.kernel.org More majordomo
> info at  http://vger.kernel.org/majordomo-info.html Please read the FAQ
> at  http://www.tux.org/lkml/

      parent reply	other threads:[~2002-10-22  3:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-21 10:16 Matt D. Robinson
2002-10-21 20:52 ` Christoph Hellwig
2002-10-21 20:48   ` Matt D. Robinson
2002-10-22  5:03     ` Christoph Hellwig
2002-10-22  8:48   ` Suparna Bhattacharya [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pan.2002.10.22.14.18.14.702192.1573@sparklet.in.ibm.com \
    --to=suparna@sparklet.in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®