From: Matthieu CASTET <castet.matthieu@free.fr>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: Re: [PATCH 4 of 6] tpm: move atmel driver off pci_dev
Date: Thu, 27 Oct 2005 23:51:58 +0200 [thread overview]
Message-ID: <pan.2005.10.27.21.51.55.561589@free.fr> (raw)
In-Reply-To: <1130253722.4839.63.camel@localhost.localdomain>
Le Tue, 25 Oct 2005 10:22:02 -0500, Kylene Jo Hall a écrit :
> +static int __init init_atmel(void)
> {
> - u8 version[4];
> int rc = 0;
> int lo, hi;
>
> - if (pci_enable_device(pci_dev))
> - return -EIO;
> + driver_register(&atml_drv);
>
> lo = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_LO);
> hi = tpm_read_index(TPM_ADDR, TPM_ATMEL_BASE_ADDR_HI);
>
Hum shouldn't you check that this port isn't used with request_region ?
Matthieu
prev parent reply other threads:[~2005-10-27 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-25 15:22 Kylene Jo Hall
2005-10-27 21:51 ` Matthieu CASTET [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pan.2005.10.27.21.51.55.561589@free.fr \
--to=castet.matthieu@free.fr \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®