Re: [PATCH] ATI Remote Control improvements

["Ville Syrjälä" <syrjala@sci.fi>]

On Wed, 10 May 2006 09:12:23 +0100, Daniel Sherwood wrote:

> 
> Hi
> 
> Please find below a patch to improve the functionality of the ATI Remote
> Control as follows.
> 
> * Fixed handling of double-click BTN_XXX events that require the
> input_event timestamp to change between press and release events.
> * Added module parameter 'xkeycodesonly' to prevent driver generating
> keycodes that are not recognised by X windows. (disabled by default)

Why?

> * Added module parameter 'selectiverepeat' to make driver only generate
> key repeats for certain keys such and cursor and volume.  (disabled by
> default)

Sounds like this sort of thing could be handled in userspace.

> * Modified filter and key repate support to use millisecond values set
> by 'filtertime', 'repeatdelay' & 'repeatrate' module parameters.

REP_DELAY and REP_PERIOD?

> * Added module parameters 'mouseascursor' & 'mouseascursordefault' to
> allow the mouse area to behave as the normal cursor-keys.  This
> functionality can optionally be switched with the 'HAND' key.  (disabled
> by default)

IIRC it already has cursor keys. Why does it need more of them?

> * Added module parameter 'mousedoubleclick' to make the double-click
> events actually send two clicks of BTN_LEFT or BTN_RIGHT rather than
> BTN_SIDE or BTN_EXTRA.  (disabled by default)
> 
> Without specifying module options, the behaviour will be the same as the
> previous version except for the BTN_XXX click fix and the filter and key
> repeat handling.


> +			if (kind == KIND_BUTTON) {
> +				struct timeval then, now;
> +				int loop = 1000000;
> +				input_sync(dev);
> +				do_gettimeofday(&then);
> +				do {
> +					do_gettimeofday(&now);
> +				} while( timeval_compare(&now, &then) ==
> 0 && loop-- );

Is this for the timestamp thing? Use udelay()?

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/