From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.176 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795245081; b=hznyQDidzUMKd7AR0yfOE0zLn0r7e9YmEkz+i2ViVNg0/3jHtSAkM+geW3GWYDKHucEb HL29wVI9C4Pg1J/yHByQNRsBfuzNKvO1BSKt1TNMz1koFBvGp6EuHE4Y2oqKijaJ0uEl4 fbNX5CYAB18QXBWH5ZD1qsJXL/YgjJ88d6L2ZCZ70SIKITe60xFGTdZHvs6H+xrHoHnDc 7P6ICOdxT7QwW9r2PkHlvtiKcq5oQrSwJ3pKbbHtyMoRnrRCkiVtO1KEFhs+uoS6d3aB3 nLanwB5rFtNGDGsjt5/J6GmIMizjzfy+UMImUSbJnHCHkV5oRmiECHCXChBnw3U7R5A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795245081; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-Id:X-Mailer:In-Reply-To:References: MIME-Version:Content-Transfer-Encoding; bh=Mna01FbMGtAeqEvxV+09r17BXVHQSxvuerCcr1g0HpI=; b=4FtYxirbVxMBNfSn1wBsOHDQCYURR9EpiC4yXfDrK+mrQgJhNQWpNh9eOVvWzLicc+K8 dDcDejrqU9YlCBsKDh/Ig2kVk+57O8y4aVta2AIS3p1LW/SsFiPTPNqtFLWv4xoY7ARNP 405b7TvKV2kVF0XLXRGCsU2uf9hgnOltRdCT0cXe8ZxvvxC8fRdhqhoydnJQuOLPxPfRT CXJbfMnCz7jZeBf99Lal6bzBOWAuz15JAO0PJW7HkRuWJG+EwajnaHacvj1Jh8jhQanKy m0vdZJHfxcAKU9PEmPLZFnuR3y1ikYsPj0FzItFycqHBESS4isv8AlalGcLPfwfgTgw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=xTIGyOY1; arc=none smtp.remote-ip=209.85.215.176 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0732A606A325 for ; Sat, 21 Nov 2026 07:11:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 0732A606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=xTIGyOY1 Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-cc4be0e5351so1663207a12.0 for ; Fri, 20 Nov 2026 23:11:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795245080; x=1795849880; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Mna01FbMGtAeqEvxV+09r17BXVHQSxvuerCcr1g0HpI=; b=xTIGyOY1M1QQyKYB6+vKmsIqR09C4ArDOBpdjvFpj5R4B6lT5BkAisOoewu5yCsOiC 6EbbIW0ip6aRnor6T7pFJjzPt3go8R2PcelYiuP9+L3CBpFXercz37+qYwZcnsmQhSj+ kh5rRaCSlEYqpVeTF9pCGFfDNFyQJ/j0hPA1XHVHz6ac3j36f/4U6bY8YsjHOQNXsYm9 ho7mlG/oANSdbrKswxiZERDWC2In8wvTtu4s1L4JHRLZ5juCxvHkbP3yVMlcr5GPUy9G So2ZyWQu2DjksCgIA8b0+c0rA4l5N1YF84ASPb5D+tJRhE/UmTkHqSaHRKuZe9rwjRYX kJWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795245080; x=1795849880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Mna01FbMGtAeqEvxV+09r17BXVHQSxvuerCcr1g0HpI=; b=mnZQwGyz2DjKRM9GjEylFXn2sONaFWdKgghMjv91zjHCfb9QNwAMU77sLwrCBuD3qg zcfFDb2jgwEWWN0dzkEDl22/OoKUw75zG9BPLpnvBeTmx2NYfYpi1cNzhlLDfE6Oa92g A5Dw97naALSwo/gkBycHnIPIKNdsIm5E/OagM3UDl/sIxcP0jB/Z6iNkwfdMrwirUrs/ JcxTavoELKVEgyMi9umIa8LX8dfyCD3nori0Ukh2/ge1TQXuvwHRhvygXIX2Kaa7IXfG ztxMbGvTnu5Mrf70XJacM1YIfqbXeBS8/NyhS76ABOuJ6HR+UwStNZzcPGxHFzRA+Gba DW/Q== X-Forwarded-Encrypted: i=1; AL+hErGwvKDwoXSKIj2krt0bL0rPjKqGRVzJoyMGgzakKchNqXW1Bd7F2SS3uiYNMBszdGGY97CiKyRfvZJnvmY=@vger.kernel.org X-Gm-Message-State: APuU4Z8yg9OWYEnKc0N/WLxF+rvSg92r/aSWzVqHHkTQJP2hJIgf8v8D kIrJiK7qA7leWVgjVTEDeiHKn//arWj+Mt5WJhn36h6fsf/t8xmaEGcI X-Gm-Gg: AZFdTZfA55xD3EeJ3x4B08xAxkR1M8O8QJHuY0M67kktggjHT5MHOGlrG778ldGJZBC qd7VCpu0kZSwhVtBMGsIGIFnB0qxbhXB6+D8nyx4jn1PvtIy7iZvtM6I2wzJYZWTKl0beBPsc7j wu20OoBX7s8pFzHCs3EHEU39HcJONh4CVFZkMaZHYxe0upghBA9mDGRIf9ZloW4LS1BGB1RdOvF FTYVgg7GXsDbMonKd481IGCNGk2CAwMWn339xEV4BhJ+yrvtMzeNJ3ME/FUcTDDTqI8EQins+xw Ne1WCkp3PgVMtoB4JTq3/5QAU0Bc68vGM7hYw4ruRvczuP9mDA7Inm3+ZWne3RGXb9Q4oAVykrg 6HDJ5nxzJiLqfnFFanS96CMGqa/nnSTrxi27SP4KYFmvzH9Y2hE390Gbv8zs9Dr26GeW2Q4HPui euDH7VL5BNa/nVLyg5sXKTjANRPHcy+gENzbLfYBBBTC0F6f1pfSZNieRtRxtUCc+mOUcJv4W4p GzAeZh/CVyhGi3iWvRCQUS2agPq9NlqnVoovKUP2dqXOUs3eFb0mH+CtDH/GDJEmUR3xq6K4ECb I5VX5CMs7Pmr622/5PyzeWOc X-Received: by 2002:a17:90b:5289:b0:3ac:c005:cf07 with SMTP id 98e67ed59e1d1-3b41c92c416mr5762251a91.42.1795245080324; Fri, 20 Nov 2026 23:11:20 -0800 (PST) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3b405d11753sm10614548a91.5.2026.11.20.23.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 23:11:20 -0800 (PST) From: Cen Zhang To: marcel@holtmann.org, luiz.dentz@gmail.com Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com, jjzuming@gmail.com, zzzccc427@gmail.com Subject: [PATCH 1/2] Bluetooth: 6lowpan: Hold RTNL across adapter lookup and use Date: Sat, 21 Nov 2026 15:11:09 +0800 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit lookup_dev() returns a borrowed adapter after dropping RCU. The last peer's asynchronous deletion can unregister and free its netdevice while a later ready callback uses that pointer: Ready callback Deletion worker lookup_dev() leave RCU lock RTNL unregister the netdevice remove the adapter from the list ifup(): wait for RTNL unlock RTNL and release storage open the stale netdevice Take RTNL before lookup and retain it through peer publication and device open. Use lowpan_register_netdevice() because registration now runs with RTNL held, and remove the nested lock from ifup(). Deletion cannot revoke the adapter between its lookup and last ready-callback use. The excerpt below retains the headline and stack traces. KASAN report as below: Oops: Oops: 0000 [#1] SMP KASAN NOPTI Workqueue: hci1 hci_rx_work RIP: 0010:dev_addr_check+0x4e/0x260 Call Trace: __dev_open+0xa8/0x6d0 ? __pfx___dev_open+0x10/0x10 netif_open+0xde/0x140 ? __pfx_netif_open+0x10/0x10 dev_open+0xb9/0x180 chan_ready_cb+0x420/0xf90 ? __pfx_chan_ready_cb+0x10/0x10 ? lockdep_init_map_type+0x5c/0x230 ? srso_alias_return_thunk+0x5/0xfbef5 ? l2cap_chan_put+0x48/0x3a0 l2cap_le_connect_req+0xccd/0x11a0 ? __pfx_l2cap_le_connect_req+0x10/0x10 l2cap_recv_frame+0x467f/0x8830 ? kfree_skbmem+0x15e/0x1d0 ? srso_alias_return_thunk+0x5/0xfbef5 ? srso_alias_return_thunk+0x5/0xfbef5 ? __mutex_lock+0x182c/0x2590 ? srso_alias_return_thunk+0x5/0xfbef5 ? __pfx_l2cap_recv_frame+0x10/0x10 ? srso_alias_return_thunk+0x5/0xfbef5 ? find_held_lock+0x2b/0x80 ? l2cap_recv_acldata+0x1eb/0x10e0 ? __pfx___mutex_lock+0x10/0x10 ? srso_alias_return_thunk+0x5/0xfbef5 ? __mutex_unlock_slowpath+0x147/0x920 ? __pfx_l2cap_conn_hold_unless_zero+0x10/0x10 ? __pfx_hci_conn_enter_active_mode+0x10/0x10 ? l2cap_recv_acldata+0x13d/0x10e0 ? srso_alias_return_thunk+0x5/0xfbef5 l2cap_recv_acldata+0xe9f/0x10e0 ? srso_alias_return_thunk+0x5/0xfbef5 hci_rx_work+0x5a6/0xf00 ? srso_alias_return_thunk+0x5/0xfbef5 process_one_work+0x908/0x19c0 ? __pfx_process_one_work+0x10/0x10 ? srso_alias_return_thunk+0x5/0xfbef5 ? lock_is_held_type+0x8f/0x100 ? srso_alias_return_thunk+0x5/0xfbef5 worker_thread+0x65c/0xe40 ? __pfx_worker_thread+0x10/0x10 kthread+0x34f/0x460 ? srso_alias_return_thunk+0x5/0xfbef5 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x659/0x940 ? __pfx_ret_from_fork+0x10/0x10 ? srso_alias_return_thunk+0x5/0xfbef5 ? __switch_to+0x74f/0xf80 ? __pfx_kthread+0x10/0x10 ret_from_fork_asm+0x1a/0x30 RIP: 0010:dev_addr_check+0x4e/0x260 Fixes: 18722c247023 ("Bluetooth: Enable 6LoWPAN support for BT LE devices") Signed-off-by: Cen Zhang --- This patch was written with assistance from Codex (OpenAI). net/bluetooth/6lowpan.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c index 68ca2f49dadc9..f01eb68cbf5a9 100644 --- a/net/bluetooth/6lowpan.c +++ b/net/bluetooth/6lowpan.c @@ -597,11 +597,11 @@ static void ifup(struct net_device *netdev) { int err; - rtnl_lock(); + ASSERT_RTNL(); + err = dev_open(netdev, NULL); if (err < 0) BT_INFO("iface %s cannot be opened (%d)", netdev->name, err); - rtnl_unlock(); } static void ifdown(struct net_device *netdev) @@ -706,7 +706,7 @@ static int setup_netdev(struct l2cap_chan *chan, struct lowpan_btle_dev **dev) list_add_rcu(&(*dev)->list, &bt_6lowpan_devices); spin_unlock(&devices_lock); - err = lowpan_register_netdev(netdev, LOWPAN_LLTYPE_BTLE); + err = lowpan_register_netdevice(netdev, LOWPAN_LLTYPE_BTLE); if (err < 0) { BT_INFO("register_netdev failed %d", err); spin_lock(&devices_lock); @@ -735,12 +735,16 @@ static inline void chan_ready_cb(struct l2cap_chan *chan) struct lowpan_btle_dev *dev; bool new_netdev = false; + /* Protect the device lookup and use against unregister. */ + rtnl_lock(); + dev = lookup_dev(chan->conn); BT_DBG("chan %p conn %p dev %p", chan, chan->conn, dev); if (!dev) { if (setup_netdev(chan, &dev) < 0) { + rtnl_unlock(); l2cap_chan_del(chan, -ENOENT); return; } @@ -748,10 +752,13 @@ static inline void chan_ready_cb(struct l2cap_chan *chan) } if (!try_module_get(THIS_MODULE)) - return; + goto out; add_peer_chan(chan, dev, new_netdev); ifup(dev->netdev); + +out: + rtnl_unlock(); } static void unregister_dev(struct lowpan_btle_dev *dev) @@ -763,7 +770,7 @@ static void unregister_dev(struct lowpan_btle_dev *dev) * * rtnl_lock -> put_device(parent) -> hci_release_dev -> * destroy_workqueue -> hci_rx_work -> l2cap_recv_acldata -> - * chan_ready_cb -> ifup -> rtnl_lock + * chan_ready_cb -> rtnl_lock * * However, hci_rx_work is disabled in hci_unregister_dev, so this * should not occur. Make lockdep happy by postponing hdev release after