From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.216.54 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795247526; b=yeQ5lyuxAX2nm6lRlmF1bn3if8v24fBuP63OHskpN7AHdWazITymv0d7Gu7a/q4sL0JD lqP5tOdm+d+EO4nJ3flRJuNfwUA9PO7q39WS4+5t7Dk4gxN8Ww0cw5ycx+DXdkrYPqr5H d1ImU6swqQQDk+DayJNTZih1OhhwixdV6EyV099CR48HUQeALnoijHyUiDEl8h4LKBFXH +3VTqDidK5gcPQnewOzqhiFg3wL2MOfOaYz3SgOzaAYGjCIA0rLLcY9g3AFMMUZ5SBByV GF2ELnVTRCziAlVxSatJPYmBGRo62me4/StmqvC2yfyUXP5Ea1w3l7CHqaPUt27sEDg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795247526; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: From:To:Cc:Subject:Date:Message-Id:X-Mailer:MIME-Version: Content-Transfer-Encoding; bh=1hYw1g33ZMFOQ7DBwiFeU4k0h/WUx3Md8Zv+IeH1Fvs=; b=T7b2IMnJHdgIDa2G4pEsD6mqeGh50sDgEUhg9M0BaS3mCgjS9i4Sq69VtNIhrCw+zJ87 Ou6T6TJIazSwCJjw1E6VuTvm0ixZmX28/2Vp+izgovkdcWKp1dPz3IMKLdBtcHU4nhEyR BaW38kbahgl4vPHZYI1WH47wOLcnrjCehUyy9D4uDGfiDiFhpn6WQ6VQr1BFy8xkPzB8R Zzji8U8TCg5btHTGBAIcinG27FfGxZtp/0HUxyVgF2K10R5xizfDootM3ehGhwgQeC26/ h4QMoxZa7oIJVuKm5L6B3IfdXtXZajDkTtyVQv+RgqCMUDqPI/p3zqz20KrCi3SGiWQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=O+gkpbZ0; arc=none smtp.remote-ip=209.85.216.54 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E86B5606A325 for ; Sat, 21 Nov 2026 07:52:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org E86B5606A325 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=O+gkpbZ0 Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-3b40d23e1adso1352168a91.0 for ; Fri, 20 Nov 2026 23:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795247525; x=1795852325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=1hYw1g33ZMFOQ7DBwiFeU4k0h/WUx3Md8Zv+IeH1Fvs=; b=O+gkpbZ0bFWcOAMp0zzqenLDkZZPHHdPU71qyJSkOakrMhknWdELDegIbChG5Thv+q rJ7uSyX8QIgEVTuF5Jf5WxxsNvSBLvgOi47Ru7NJVUjxlPVnD824tCvxETBOZP1XLImU Ly3qpiWATfGbmh7DS4SSlXMbBlxetKDJEq/1Kac9GNzbtfc0vbWK/Ml74WIUoO/1bTnz QxEQ91bzwrFDfKJLpHvr6wFLR4PhiIpgsaxFHtN9Dz2yJp7IFzya5ztEHnUNLcza6FXj s/MxbhkZXaVqWV+3hhNCG9IJ4BVX96SrOZUQk2DTXxYlW8X/S3NxKupfRwCGd51cHfqC 8+BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795247525; x=1795852325; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1hYw1g33ZMFOQ7DBwiFeU4k0h/WUx3Md8Zv+IeH1Fvs=; b=TeZ7307Ai2aQvD7MPR+6VqK1YgUYtTw1ZhD7dyis3gCvBAJ4OjJ+luWne4EDpHMReJ W3grZ2SMPaf/6ki9jjLi36uL9KYyZuft2nguEnnfywZyUPLrY1FMGZKWuEjS1/L2pc/a lZY9rW1fPK7z6QnYIXJIBcWuKIIAs5eEQOpQWZzFENzkf3RRbeK/K3akZQ45tZ+mNOb1 w1I3AGzNEaOhWAnIB4ci0Cy56nHDxn5qU03JXVZ1YJVv6gZ/5WMJmYxRyOaNzcA5CDjG TN3H7iv0TToR3cFkXjQaJ3FqpEazQGDQZhRTNmPVXITpiv3Pw4IWjCP9Y8MQ9mcWF4Ao UIOA== X-Forwarded-Encrypted: i=1; AL+hErFLDlMD7DNsQ95H7wR8GOuWP7arlUY1A2yM72Ud8+J7iC2q13yXE/2obVeuUeUH33xhPBUuuEAvIXhYrXg=@vger.kernel.org X-Gm-Message-State: APuU4Z9GvPlCFcqJ2ld1E3jat+S2SzWSEYzLbi3eqx37TRH2ijC3PpzC rkNhYyDB5El+fEm8/waHA9jdaCSN9psGHTZxZOHXHhE+vFDtcwf6nXps/U0akAhiWKo= X-Gm-Gg: AZFdTZchbtTRZSnSC8dlwO6+1HbDUNzj0AsOdSCkbvNOgH2H7rr+uJyAh0FNj9MMg33 FHGLLfIHu7P9WKUsfeeT8mDc9JEti9KMTTpLxljxHW5YhdEZLQN+QsXelSvaqkdhbD4HR6oCjjH Jacfn+CoCcl40gBgr5Ypjt3elXp6LnMRADEkgWn4lNlhGv269zJGRDzHgek25S99zKCVvAUCAE4 FQft6AZCPW4+kVGItN4j5MCQxk32nlGiFxg+FybkPqWavIKpIUVXAY4536AAaKFdGq8UopurDdV B4pQ5vNlORHql/D/dm+j6444H1gzP6iqzcJ2kQXsICUEv04zmVGYRZRP41PNcbi6121FLZ7kPIh owoI2gfWYIMPag9kV0lPsosP3MLOrZJ9ddMwR5QNolQjUWWX2R194cQdhrVHZg2uA8Wpp5Yy1ap wQO6RpKoyJcMDI3huOGJIt4pWT6vhh8tEPtGxH24ghydvCvvE5tANrlmBzcCnaVBChjgyu1d/t6 zuAuI2qY4iatFP+qNui7EIkbowTtn/E+SgenMMn/Zg891ki5GwqkFCQU5sgBlwNea6MrkbWNCvo kBLsXtSZtjetPu40wU2g9hTq X-Received: by 2002:a17:90b:17cb:b0:3b0:cc6f:1046 with SMTP id 98e67ed59e1d1-3b41c9bc517mr5638283a91.67.1795247525168; Fri, 20 Nov 2026 23:52:05 -0800 (PST) Received: from localhost ([111.228.63.84]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cde6cfec090sm2401719a12.14.2026.11.20.23.52.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Nov 2026 23:52:04 -0800 (PST) From: Cen Zhang To: mark@fasheh.com, jlbec@evilplan.org, joseph.qi@linux.alibaba.com Cc: heming.zhao@suse.com, ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org, baijiaju1990@gmail.com, jjzuming@gmail.com, zzzccc427@gmail.com Subject: [PATCH v3] ocfs2: drain fs_state readers before journal teardown Date: Sat, 21 Nov 2026 15:51:57 +0800 Message-Id: X-Mailer: git-send-email 2.34.1 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fs_state debugfs open callback builds a snapshot from mount state, including the journal and cluster connection. The file is published before ocfs2_mount_volume() and removed after journal and DLM shutdown, so an open can overlap teardown on unmount or mount failure. Publish fs_state at the successful end of ocfs2_fill_super(), after the last fallible mount step. Remove it in ocfs2_put_super() before calling ocfs2_dismount_volume(). Debugfs removal excludes new opens and drains active callbacks. The release callback only frees the per-open snapshot. KASAN reported: BUG: KASAN: slab-use-after-free in ocfs2_osb_debug_open+0x967/0x15e0 Read of size 4 at addr ffff888116a56028 by task cat/502 ... Freed by task 504: kfree+0x308/0x580 ocfs2_journal_shutdown+0x10a/0xc20 ocfs2_dismount_volume+0x315/0x940 Fixes: da5e7c87827e ("ocfs2: cleanup journal init and shutdown") Cc: stable@vger.kernel.org Signed-off-by: Cen Zhang --- Changes in v3: - Create fs_state at the successful end of ocfs2_fill_super() so failed mounts never publish it. - Remove fs_state in ocfs2_put_super() before volume teardown so creation and removal are paired at the superblock level (Joseph Qi). Changes in v2: - Address the osb dereference before BUG_ON(!osb) raised by Sashiko: https://sashiko.dev/#/patchset/98583 - Remove fs_state after BUG_ON(!osb) in ocfs2_dismount_volume(). - Trim the KASAN report. Link to v1: https://lore.kernel.org/r/pm-ocfs2-objects-candidate-0003-v6-2f69dbb7417fcd537be6@gmail.com Link to v2: https://lore.kernel.org/r/pm-ocfs2-objects-candidate-0003-v7-1522d068e5b943786c3e@gmail.com This patch was written with assistance from Codex (OpenAI). fs/ocfs2/super.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index 0af2245ae303..2a58d3cd9690 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -1072,9 +1072,6 @@ static int ocfs2_fill_super(struct super_block *sb, struct fs_context *fc) osb->osb_debug_root = debugfs_create_dir(osb->uuid_str, ocfs2_debugfs_root); - debugfs_create_file("fs_state", S_IFREG|S_IRUSR, osb->osb_debug_root, - osb, &ocfs2_osb_debug_fops); - if (ocfs2_meta_ecc(osb)) { ocfs2_initialize_journal_triggers(sb, osb->s_journal_triggers); ocfs2_blockcheck_stats_debugfs_install( &osb->osb_ecc_stats, @@ -1158,6 +1155,10 @@ static int ocfs2_fill_super(struct super_block *sb, struct fs_context *fc) /* Start this when the mount is almost sure of being successful */ ocfs2_orphan_scan_start(osb); + /* Publish fs_state only after all fallible mount steps. */ + debugfs_create_file("fs_state", 0400, osb->osb_debug_root, + osb, &ocfs2_osb_debug_fops); + return status; out_dismount: @@ -1555,8 +1556,13 @@ static void __exit ocfs2_exit(void) static void ocfs2_put_super(struct super_block *sb) { + struct ocfs2_super *osb = OCFS2_SB(sb); + trace_ocfs2_put_super(sb); + /* Drain fs_state opens before releasing their backing state. */ + debugfs_lookup_and_remove("fs_state", osb->osb_debug_root); + ocfs2_sync_blockdev(sb); ocfs2_dismount_volume(sb, 0); }