From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailgw.kylinos.cn (mailgw.kylinos.cn [124.126.103.232]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8465525F99F for ; Fri, 7 Aug 2026 03:31:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=124.126.103.232 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786073504; cv=none; b=K7hhbHq1NkTjO5oUiDYv8+13hyK+lJGrKDi9HrOjw7iTLUNg1tAnMcxygasACj+oJCjAnPKq4iMbsnM7zDLH3zc7RzquwQprpsdY4HUIUtAYxDgTsBopkEmysoOVnRiMM4kDR3sgfkZaqiYFjuI26LrB9CXl0ZE3GRHdi3A0qx0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786073504; c=relaxed/simple; bh=aa8Shcj9Lpe0MML1tB1dRx4Ch963woePc0Eh6xGZu4w=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=lPm/iK3FTXxfY/R1R3de6/lZKaP0ewK+h/4+qvJ0+iOTsMvad3iQJ0kHjVuuwpeL2+j+W0cNmyHlN3ixu+pGcHCReBFZ1HGX4+Ftch5e29CmR9jtV32MEqC89XmTkE8Dft3DzPkKeksSYrpGVWaMkI3lXfEIgPuy5jpwmOwgasE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn; spf=pass smtp.mailfrom=kylinos.cn; arc=none smtp.client-ip=124.126.103.232 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kylinos.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kylinos.cn X-UUID: 7d35d3b6921011f1aa26b74ffac11d73-20260807 X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.3.12,REQID:239a4416-a78f-4cde-8a7a-971fdd4509ab,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:e7bac3a,CLOUDID:58481a91c5a73d8ca54b7e90130cdc05,BulkI D:nil,BulkQuantity:0,Recheck:0,SF:81|82|102|865|898,TC:nil,Content:0|15|50 ,EDM:-3,IP:nil,URL:0,File:nil,RT:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,O SA:0,AV:0,LES:1,SPR:NO,DKR:0,DKP:0,BRR:0,BRE:0,ARC:0 X-CID-BVR: 2,SSN|SDN X-CID-BAS: 2,SSN|SDN,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-CID-RHF: D41D8CD98F00B204E9800998ECF8427E X-UUID: 7d35d3b6921011f1aa26b74ffac11d73-20260807 X-User: liuxixin@kylinos.cn Received: from [127.0.1.1] [(10.44.16.150)] by mailgw.kylinos.cn (envelope-from ) (Generic MTA with TLSv1.3 TLS_AES_256_GCM_SHA384 256/256) with ESMTP id 2051555578; Fri, 07 Aug 2026 11:31:34 +0800 From: Xixin Liu To: linuxppc-dev@lists.ozlabs.org Cc: maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, chleroy@kernel.org, linux-kernel@vger.kernel.org, liuxixin@kylinos.cn Subject: [PATCH v1 2/4] powerpc/powernv: opal-imc: fix debugfs name buffer size Date: Fri, 07 Aug 2026 11:11:14 +0800 Message-ID: In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: patches/scripts/send-local.py char mode[16]/cmd[16] are too small for sprintf("imc_mode_%d") / sprintf("imc_cmd_%d") when id is a full u32 (up to 20 bytes including NUL). id comes from DT "chip-id" as u32. Enlarge the buffers and use snprintf. Signed-off-by: Xixin Liu --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/platforms/powernv/opal-imc.c b/arch/powerpc/platforms/powernv/opal-imc.c index b3fd5c648dea..77de53d47cb6 100644 --- a/arch/powerpc/platforms/powernv/opal-imc.c +++ b/arch/powerpc/platforms/powernv/opal-imc.c @@ -51,7 +51,8 @@ struct imc_pmu *pmu_ptr) { static u64 loc, *imc_mode_addr, *imc_cmd_addr; - char mode[16], cmd[16]; + /* "imc_mode_" / "imc_cmd_" + max u32 decimal + NUL */ + char mode[20], cmd[20]; u32 cb_offset; struct imc_mem_info *ptr = pmu_ptr->mem_info; @@ -63,12 +64,12 @@ while (ptr->vbase != NULL) { loc = (u64)(ptr->vbase) + cb_offset; imc_mode_addr = (u64 *)(loc + IMC_CNTL_BLK_MODE_OFFSET); - sprintf(mode, "imc_mode_%d", (u32)(ptr->id)); + snprintf(mode, sizeof(mode), "imc_mode_%u", ptr->id); imc_debugfs_create_x64(mode, 0600, imc_debugfs_parent, imc_mode_addr); imc_cmd_addr = (u64 *)(loc + IMC_CNTL_BLK_CMD_OFFSET); - sprintf(cmd, "imc_cmd_%d", (u32)(ptr->id)); + snprintf(cmd, sizeof(cmd), "imc_cmd_%u", ptr->id); imc_debugfs_create_x64(cmd, 0600, imc_debugfs_parent, imc_cmd_addr); ptr++; -- 2.43.0