From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756214Ab0CaOlb (ORCPT ); Wed, 31 Mar 2010 10:41:31 -0400 Received: from mail-pw0-f46.google.com ([209.85.160.46]:49151 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755209Ab0CaOl3 convert rfc822-to-8bit (ORCPT ); Wed, 31 Mar 2010 10:41:29 -0400 MIME-Version: 1.0 In-Reply-To: <20100331070648.GA23391@pengutronix.de> References: <1269972879-27400-1-git-send-email-mroberto@cpti.cetuc.puc-rio.br> <20100331070648.GA23391@pengutronix.de> From: Marcelo Jimenez Date: Wed, 31 Mar 2010 11:41:07 -0300 Message-ID: Subject: Re: [PATCH] ARM: pcmcia: Adds nanoEngine PCMCIA support. To: Wolfram Sang Cc: Russell King , Ralf Baechle , Eric Miao , Dominik Brodowski , Manuel Lauss , Dmitry Artamonow , "Rafael J. Wysocki" , linux-pcmcia@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolgram, On Wed, Mar 31, 2010 at 04:06, Wolfram Sang wrote: > Hi Marcelo, > > On Tue, Mar 30, 2010 at 03:14:39PM -0300, Marcelo Roberto Jimenez wrote: >> This patch adds nanoEngine PCMCIA support, with support for two sockets. >> ... >> + >> +     memset(state, 0, sizeof(struct pcmcia_state)); >> +     switch (i) { >> +     case 0: >> +             state->ready    =  (levels & GPIO_PC_READY0)    ? 1 : 0; >> +             state->detect   = !(levels & GPIO_PC_CD0)       ? 1 : 0; > > If lines are added at a later stage, all this indentation might have to be > redone. This breaks 'git blame'. Please just one space around operators as > suggested in CodingStyle, chapter 3.1. Sorry, I didn't know about that. I ran the patch through checkpatch.pl and it did not complain, so I thought it was ok. I will change that and resubmit. >> + >> +int pcmcia_nanoengine_init(struct device *dev) >> +{ >> +     int ret = -ENODEV; >> + >> +     printk(KERN_INFO "BSE nanoEngine pcmcia support by " >> +             "Miguel Freitas & Marcelo Jimenez.\n"); > > Is this really necessary? Log would get quite messy if all drivers do this. > I haven't checked, can't you just use MODULE_AUTHOR here? I can remove it, in fact. It was there at the first version of the driver, so I just added my name. In this case, this file becomes part of another module, in this case the module is "sa1100_cs", so I don't think I could add MODULE_AUTHOR there, but I could use some advice here. > > -- > Pengutronix e.K.                           | Wolfram Sang                | > Industrial Linux Solutions                 | http://www.pengutronix.de/  | Thanks for your comments, Marcelo.