From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69F8F54EEB2 for ; Wed, 14 Oct 2026 15:24:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791991480; cv=none; b=gxKpRHQF36XFtBBd0yfiv7Jzsc4h4dFeGFGN+88vz4kiJXm8LE6UL0n9wHPAwpxXF9yY5MiNAITMWjEyx/JSiwrM/FAj0NBELZfSRS+Nky/dPEhu6pnhi+N+z152YKMkxHi0Mdi9BypObdHumaGEwClu+rSZ5iHURm/vaQNuB5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791991480; c=relaxed/simple; bh=wSZ3zwnVBwhfAGt5ifjj+oFVu2p72JS9QMJwu71vpk4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qCJsXSVp9+xnMLVfat+/f1dSshu4Hk/gIe3V+zVb9VJLHWUG88n/UGffTj0eUb9e4rcSIfQawWDEldHAnon/mKWrI9D+3hvTIMo0CHNM8/4dXIeAX/yC7XFDD0/6YGVuhS/Or+fZBKFDL7Vwz3Do52EkeAZGCqExWd/OwtrsONM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QfBE8ICn; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QfBE8ICn" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-cc4dbcf2b85so577531a12.3 for ; Wed, 14 Oct 2026 08:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791991479; x=1792596279; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=t7IRL6SEiSa3rzeqlbvDCyLB5N7LUmPGMrQiBUcualE=; b=QfBE8ICnBaTlQIr0Ew8EulgJJxMWQQT9rxQSB5J859fwuJcD/OCaK62L9R4xp/udf5 yNLrfnHILV6s+dZskFPnkl4JALRizQYL+ubN/tJlcCm2oH0L6q4P5gBNDe4v896lsjZA 5RSPqiuplVAaxH7EqehwTjdsQYlfED3WDSEOYAjpqI5fwLUYkIgvs3KpYiaotthaWbDC eW1WuOE15ISxXG73RbwahGFKPtJ9lpSkOrS/XcCW47id0Vn281+iYgaAsJFZslBJvFSN DB/oA3sd1ZCStE5zhEnILwpLHJUQZUFsgH4KRHZJpl3/pdRUbmNUkBjFYWum+POckq6w rcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791991479; x=1792596279; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=t7IRL6SEiSa3rzeqlbvDCyLB5N7LUmPGMrQiBUcualE=; b=IZQHFJSBquXKa86n022qYcv35K1d9dfvtZM2yKeVw6EOGBuyq/zrsVvZtDmw4p+YJE 9t+jgT3uuO/KAW4G8dSd8DnTPXbTOrW0+NUQr8cn2WF6hBp61xondyia7aIiqmkn/F6V SG2ZjW92IMXAs4yu1YBu4Jzx+wIWBSC/EpXvLPSdvxY4Lso6HMPZKLcH/FeHRKvnYtq6 cNUYv+XqbSlYZyOeAbPoAy/s0eCgqd2/ispTlaJhzPok/Hyo9Dyzgn+B3l1p1BmZHfJ6 SDDUfF2dWUK6ncIU1490WkNugY54MYhJiJWOvCa+PmndARUMaU8llHpCXXKqd9tTtuEM 705Q== X-Forwarded-Encrypted: i=1; AKwUvBzNw4zbXUjf+ClGFq5ZnnwnIqmv7boTxxciT2wWzxN8IxtS1BHC4IdENrlDnFhBya4MZ6NDyGKdTltDzlo=@vger.kernel.org X-Gm-Message-State: AFq9FYK8vKG+l01VlasqfyD3ZWJCwEt9q/uVKvvFCSeZMYRbRGT5A0sW y8ZT/FzOKIwOHAVMj5ixemlaway7E23DWzIeoQUBbbf9Jv59bFJ6aFmZu8YvYA== X-Gm-Gg: AYBFou1sp7I9+grZgZ/Zh67M1BPpw+awF7iq6MASbyxU2RlOQKftch9bEpLm6yeCrGX HTClwHS6yDcovLkU7PsyXYjRjIi2U4xPrfZNqMoWRjBqMWcLFswY7BMo+kczGgrDlq3phrTnRj3 /Tur9ELioqVO6cG3wyHi8yX5aBoZGBUbsM63c/TtQY+Bhc+ItL9RrWg0PEj5H8WidLT0c3/e/gX Lne1HaNE1YicIvg36JOkIqYVE554nflKnifQH7zjhK402i976dyM/B1v5nEaFHOPg8k3kqlW0A4 AlVIXrlf6IE3XADL5WHGjALQ52rszJOzvq5XMkFYDwnf1ILWGWrUFdNpIhE1ymj9lZOnXuWPSFg i5SJNzwTfUVgDL6SYvidNRQ9GCzH9jGtZjxb9g9fKqrxyEek56pJ0iuKhTb8I1kV7xUnUCbBNt+ qi6+HFFZ1CiRQaSGb1kCKgc9mo1gVLxRVE2uzX00lF/xx+a8vMsUBJXZ/Edlkkjy1ZdTjWnpaMQ W1pxNxqM8Sk7jPDpMxBZeisSuiRa9Ek1EwCFWuP+wQLyRoXDUl8WnWuw1xOuYOzuikRMBSTL2HU 9jOx+88KMUe/tsY= X-Received: by 2002:a17:90b:4c04:b0:3ac:80dc:f40a with SMTP id 98e67ed59e1d1-3ac80dd0188mr1244754a91.16.1791991478624; Wed, 14 Oct 2026 08:24:38 -0700 (PDT) Received: from localhost.localdomain ([180.182.24.11]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-cd3d9e08905sm7169469a12.9.2026.10.14.08.24.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 14 Oct 2026 08:24:37 -0700 (PDT) From: Joonho Lee To: Takashi Iwai Cc: Takashi Iwai , Jaroslav Kysela , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: [RFC PATCH v3 1/2] ALSA: pcm: allow capture reads while draining Date: Thu, 15 Oct 2026 00:24:22 +0900 Message-ID: In-Reply-To: References: <8733u8g0kh.wl-tiwai@suse.de> <87y0c0el29.wl-tiwai@suse.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Allow capture transfer calls in DRAINING so already captured tail frames remain readable until drain completes. Assisted-by: LLM Signed-off-by: Joonho Lee --- sound/core/pcm_lib.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index 4d665b4148d7..de952f639d3b 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c @@ -2208,13 +2208,17 @@ static int pcm_sanity_check(struct snd_pcm_substream *substream) return 0; } -static int pcm_accessible_state(struct snd_pcm_runtime *runtime) +static int pcm_accessible_state(struct snd_pcm_substream *substream) { + struct snd_pcm_runtime *runtime = substream->runtime; + switch (runtime->state) { case SNDRV_PCM_STATE_PREPARED: case SNDRV_PCM_STATE_RUNNING: case SNDRV_PCM_STATE_PAUSED: return 0; + case SNDRV_PCM_STATE_DRAINING: + return substream->stream == SNDRV_PCM_STREAM_CAPTURE ? 0 : -EBADFD; case SNDRV_PCM_STATE_XRUN: return -EPIPE; case SNDRV_PCM_STATE_SUSPENDED: @@ -2320,7 +2324,7 @@ snd_pcm_sframes_t __snd_pcm_lib_xfer(struct snd_pcm_substream *substream, nonblock = !!(substream->f_flags & O_NONBLOCK); snd_pcm_stream_lock_irq(substream); - err = pcm_accessible_state(runtime); + err = pcm_accessible_state(substream); if (err < 0) goto _end_unlock; @@ -2388,7 +2392,7 @@ snd_pcm_sframes_t __snd_pcm_lib_xfer(struct snd_pcm_substream *substream, atomic_dec(&runtime->buffer_accessing); if (err < 0) goto _end_unlock; - err = pcm_accessible_state(runtime); + err = pcm_accessible_state(substream); if (err < 0) goto _end_unlock; appl_ptr += frames;