mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: <akpm@osdl.org>
Cc: <sam@ravnborg.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix file2alias for cross builds
Date: Tue, 17 May 2005 14:47:17 +0200	[thread overview]
Message-ID: <s289f5e1.002@emea1-mh.id2.novell.com> (raw)

Could you point out what compiler version you saw this with? Assuming you did a native build, I tried (for HOSTCC) gcc 3.3.3, 3.4.3, and 4.0.0, none of which caused the problems you saw. Thanks, Jan

>>> Andrew Morton <akpm@osdl.org> 16.05.05 09:37:13 >>>
"Jan Beulich" <JBeulich@novell.com> wrote:
>
> When doing cross builds for 64-bit targets on 32-bit platforms, 64-bit
>  types may not have the same alignment on build and target platforms,
>  causing problems when parsing the ieee1394_device_id structures. This
>  adds explicit alignment to the 64-bit type used in file2alias.
> 
>  Signed-off-by: Jan Beulich <jbeulich@novell.com>
> 
>  diff -Npru linux-2.6.12-rc4.base/scripts/mod/file2alias.c linux-2.6.12-rc4/scripts/mod/file2alias.c
>  --- linux-2.6.12-rc4.base/scripts/mod/file2alias.c	2005-05-11 17:28:26.866988056 +0200
>  +++ linux-2.6.12-rc4/scripts/mod/file2alias.c	2005-05-11 17:50:36.316880952 +0200
>  @@ -17,7 +17,8 @@
>   #if KERNEL_ELFCLASS == ELFCLASS32
>   typedef Elf32_Addr	kernel_ulong_t;
>   #else
>  -typedef Elf64_Addr	kernel_ulong_t;
>  +/* This can't be a typedef as otherwise the attribute gets ignored. */
>  +#define kernel_ulong_t __attribute__((__aligned__(8))) Elf64_Addr
>   #endif
>   #ifdef __sun__
>   #include <inttypes.h>

It breaks ia64:

In file included from scripts/mod/file2alias.c:36:
include/linux/mod_devicetable.h:21: parse error before `__attribute__'
include/linux/mod_devicetable.h:21: warning: no semicolon at end of struct or union
include/linux/mod_devicetable.h:36: parse error before `__attribute__'
include/linux/mod_devicetable.h:36: warning: no semicolon at end of struct or union
include/linux/mod_devicetable.h:118: parse error before `__attribute__'
include/linux/mod_devicetable.h:118: warning: no semicolon at end of struct or union
include/linux/mod_devicetable.h:142: parse error before `__attribute__'
include/linux/mod_devicetable.h:142: warning: no semicolon at end of struct or union
include/linux/mod_devicetable.h:156: parse error before `__attribute__'
include/linux/mod_devicetable.h:156: warning: no semicolon at end of struct or union
include/linux/mod_devicetable.h:161: parse error before `__attribute__'
include/linux/mod_devicetable.h:161: warning: no semicolon at end of struct or union
include/linux/mod_devicetable.h:165: parse error before `}'
scripts/mod/file2alias.c: In function `do_usb_entry':
scripts/mod/file2alias.c:60: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:60: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:60: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:60: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:60: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:62: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:62: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:62: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:62: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:62: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:73: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:76: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:76: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:76: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:76: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:76: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:78: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:78: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:78: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:78: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:78: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:81: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:81: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:81: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:81: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:81: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:84: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:84: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:84: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:84: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:84: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:87: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:87: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:87: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:87: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:87: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:90: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:90: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:90: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:90: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:90: dereferencing pointer to incomplete type
scripts/mod/file2alias.c: In function `do_usb_entry_multi':
scripts/mod/file2alias.c:107: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:107: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:108: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:108: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:109: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:109: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:111: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:112: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:113: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:114: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:120: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:120: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:120: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:124: dereferencing pointer to incomplete type
scripts/mod/file2alias.c: In function `do_usb_table':
scripts/mod/file2alias.c:149: sizeof applied to an incomplete type
scripts/mod/file2alias.c: In function `do_ieee1394_entry':
scripts/mod/file2alias.c:166: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:166: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:167: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:167: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:168: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:168: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:169: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:169: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:170: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:170: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:173: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:173: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:173: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:173: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:173: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:175: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:175: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:175: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:175: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:175: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:177: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:177: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:177: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:177: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:177: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:179: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:179: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:179: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:179: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:179: dereferencing pointer to incomplete type
scripts/mod/file2alias.c: In function `do_pci_entry':
scripts/mod/file2alias.c:193: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:193: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:194: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:194: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:195: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:195: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:196: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:196: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:197: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:197: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:198: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:198: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:201: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:201: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:201: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:201: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:201: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:202: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:202: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:202: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:202: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:202: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:203: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:203: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:203: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:203: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:203: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:204: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:204: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:204: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:204: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:204: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:206: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:207: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:208: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:209: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:210: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:211: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:218: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:190: warning: `baseclass' might be used uninitialized in this function
scripts/mod/file2alias.c:190: warning: `subclass' might be used uninitialized in this function
scripts/mod/file2alias.c:190: warning: `interface' might be used uninitialized in this function
scripts/mod/file2alias.c:191: warning: `baseclass_mask' might be used uninitialized in this function
scripts/mod/file2alias.c:191: warning: `subclass_mask' might be used uninitialized in this function
scripts/mod/file2alias.c:191: warning: `interface_mask' might be used uninitialized in this function
scripts/mod/file2alias.c: In function `do_ccw_entry':
scripts/mod/file2alias.c:232: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:232: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:233: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:233: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:234: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:234: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:235: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:235: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:236: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:236: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:239: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:239: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:239: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:239: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:239: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:241: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:241: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:241: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:241: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:241: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:243: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:243: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:243: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:243: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:243: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:245: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:245: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:245: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:245: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:245: dereferencing pointer to incomplete type
scripts/mod/file2alias.c: In function `do_pnp_entry':
scripts/mod/file2alias.c:272: dereferencing pointer to incomplete type
scripts/mod/file2alias.c: In function `do_pnp_card_entry':
scripts/mod/file2alias.c:282: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:284: dereferencing pointer to incomplete type
scripts/mod/file2alias.c:286: dereferencing pointer to incomplete type
scripts/mod/file2alias.c: In function `handle_moddevtable':
scripts/mod/file2alias.c:346: sizeof applied to an incomplete type
scripts/mod/file2alias.c:352: sizeof applied to an incomplete type
scripts/mod/file2alias.c:355: sizeof applied to an incomplete type
scripts/mod/file2alias.c:361: sizeof applied to an incomplete type
scripts/mod/file2alias.c:364: sizeof applied to an incomplete type
make[2]: *** [scripts/mod/file2alias.o] Error 1
make[1]: *** [scripts/mod] Error 2
make: *** [scripts] Error 2


             reply	other threads:[~2005-05-17 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-17 12:47 Jan Beulich [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-05-12  8:57 Jan Beulich
2005-05-16  7:37 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s289f5e1.002@emea1-mh.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®