From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757839Ab0EMBMn (ORCPT ); Wed, 12 May 2010 21:12:43 -0400 Received: from smtp-out.google.com ([216.239.44.51]:25542 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752038Ab0EMBMm convert rfc822-to-8bit (ORCPT ); Wed, 12 May 2010 21:12:42 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=mime-version:in-reply-to:references:date:message-id:subject:from:to: cc:content-type:content-transfer-encoding:x-system-of-record; b=EIpBX1oQh/SUjRaRIq41NFAI7SkNWUE5jJUaUMSlgTS/SEwDVcc0eWxvYac5q8qDY lwkZ8MF2Wjw53JaICh4RQ== MIME-Version: 1.0 In-Reply-To: <1195.1273664737@redhat.com> References: <1273634462-2672-1-git-send-email-walken@google.com> <1273634462-2672-5-git-send-email-walken@google.com> <1195.1273664737@redhat.com> Date: Wed, 12 May 2010 18:12:38 -0700 Message-ID: Subject: Re: [PATCH 04/12] rwsem: consistently use adjustment variable From: Michel Lespinasse To: David Howells Cc: Linus Torvalds , Ingo Molnar , Thomas Gleixner , LKML , Andrew Morton , Mike Waychison , Suleiman Souhlal , Ying Han Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 12, 2010 at 4:45 AM, David Howells wrote: > From a human point of view, I would say keep woken, but use it to initialise > adjustment: > >        adjustment = woken * RWSEM_ACTIVE_READ_BIAS; > > and use it to initialise 'loop': > >        for (loop = woken; loop > 0; loop--) { Sounds good. I'll have it in next version. (Arguably 'woken' might be confusing too given that we only wake the threads later on. But I don't care much either way). -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies.