From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27611C4338F for ; Sun, 15 Aug 2021 07:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F21E360524 for ; Sun, 15 Aug 2021 07:30:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236570AbhHOHbV (ORCPT ); Sun, 15 Aug 2021 03:31:21 -0400 Received: from smtp-out1.suse.de ([195.135.220.28]:38298 "EHLO smtp-out1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236146AbhHOHbU (ORCPT ); Sun, 15 Aug 2021 03:31:20 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out1.suse.de (Postfix) with ESMTP id D443821FA2; Sun, 15 Aug 2021 07:30:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1629012649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQu1Y0kxtEnpxUwvGLssrYAMhEy0FrOA3iD90t/w9Zk=; b=yN9qjr74IDs+wJ+QSTHaPbRVzlfR130BViKyGd6DNF9Sa29nJbtom/EV2M9Rmim1dVD1/a giTOKoZEJwMvhXvopk9Iy+Hecv7C0nIbI/Qo32G1i8hmqaqlpGZ5F1RT/TtZjmaap/0dPm 9yNsPTEYxEEEvUYBR4fIYlYQeim8CzA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1629012649; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fQu1Y0kxtEnpxUwvGLssrYAMhEy0FrOA3iD90t/w9Zk=; b=VB0Z+o90fU42qneGrVb0LKXG+fWNgB7XwLSsvGbw1a90qAx1XZSDt7ST2FCq7nfvZKGB0x 41MsLULR9FttM/Aw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id B2F5FA3B83; Sun, 15 Aug 2021 07:30:49 +0000 (UTC) Date: Sun, 15 Aug 2021 09:30:49 +0200 Message-ID: From: Takashi Iwai To: Kristin Paget Cc: Takashi Iwai , alsa-devel@alsa-project.org, Jaroslav Kysela , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 15 Aug 2021 00:46:05 +0200, Kristin Paget wrote: > > The 2021-model XPS 15 appears to use the same 4-speakers-on-ALC289 audio > setup as the Precision models, so requires the same quirk to enable woofer > output. Tested on my own 9510. > > Signed-off-by: Kristin Paget It seems that your MUA broken the patch (tabs converted to spaces). Since it's a trivial oneliner, I applied manually. But for the next time, please try to fix your MUA setup. Thanks! Takashi