From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95284C4338F for ; Fri, 13 Aug 2021 06:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7758F6109D for ; Fri, 13 Aug 2021 06:10:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238801AbhHMGLQ (ORCPT ); Fri, 13 Aug 2021 02:11:16 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:40308 "EHLO smtp-out2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234716AbhHMGLP (ORCPT ); Fri, 13 Aug 2021 02:11:15 -0400 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id E810E1FD90; Fri, 13 Aug 2021 06:10:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1628835047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JtlNSEjo/aAGUyeOb1fWgW8Jo9JxLdbdVNlnrm++LWM=; b=gCyH+u89wcAxHSXRzVLE7LRQGjVdUF5Yfbdr3Jc6BieHi2xbtch0JKriDS3ydz5lGfCs5O XybX+4XM1Smk0bTcmFz1poRg9YAz7Irw6vd2tq2Z5s6A3OppzzBahz84AA8FTF2POjjyFF l88HNwcR8Q8ZdinuZmipf/cj5wBPzPw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1628835047; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JtlNSEjo/aAGUyeOb1fWgW8Jo9JxLdbdVNlnrm++LWM=; b=Nf4AzfPJJZhIe1hEDRIaJEVNBJRzlFvxuoPL1r+4ybXT3OISzpTb+nWwVGV3AZoalHjZz/ 8fPLFbsp/EtqHUAw== Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42]) by relay2.suse.de (Postfix) with ESMTP id DC400A3B84; Fri, 13 Aug 2021 06:10:47 +0000 (UTC) Date: Fri, 13 Aug 2021 08:10:47 +0200 Message-ID: From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , , , , Stefan Binding Subject: Re: [PATCH 2/2] ALSA: hda/cs8409: Prevent pops and clicks during reboot In-Reply-To: <20210812183433.6330-2-vitalyr@opensource.cirrus.com> References: <20210812183433.6330-1-vitalyr@opensource.cirrus.com> <20210812183433.6330-2-vitalyr@opensource.cirrus.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Aug 2021 20:34:33 +0200, Vitaly Rodionov wrote: > > From: Stefan Binding > > During reboot, when the CS42L42 powers down, pops and clicks > may occur due to the codec not being shutdown gracefully. > This can be fixed by going through the suspend sequence, > which shuts down the codec cleanly inside the reboot_notify > hook, which is called on reboot. > > Signed-off-by: Stefan Binding > Signed-off-by: Vitaly Rodionov I hold this one for now, as there is a fix series that deprecates the reboot_notify callback of HD-audio by forcibly doing runtime-suspend at shutdown. Please check the three patches in https://bugzilla.kernel.org/show_bug.cgi?id=214045 I'm going to submit those soon in anyway. thanks, Takashi