From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D31ADC5DF9D for ; Thu, 29 Oct 2020 01:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A2BD2075E for ; Thu, 29 Oct 2020 01:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733026AbgJ2BX1 (ORCPT ); Wed, 28 Oct 2020 21:23:27 -0400 Received: from mx2.suse.de ([195.135.220.15]:47932 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729804AbgJ1WDm (ORCPT ); Wed, 28 Oct 2020 18:03:42 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 82F16B1BE; Wed, 28 Oct 2020 19:38:19 +0000 (UTC) Date: Wed, 28 Oct 2020 20:38:19 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: tiwai@suse.com, perex@perex.cz, hui.wang@canonical.com, kai.vehmanen@linux.intel.com, mwolf@adiumentum.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 0/3] HDA controller PM and codec PM cleanups In-Reply-To: <20201027130038.16463-1-kai.heng.feng@canonical.com> References: <20201027130038.16463-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 27 Oct 2020 14:00:35 +0100, Kai-Heng Feng wrote: > > While working on the issue "ALSA: hda: fix jack detection with Realtek > codecs when in D3", I've found using pm_runtime_force_{suspend,resume}() > have surprising behavior, specifically, pm_runtime_need_not_resume() > uses pm_runtime_need_not_resume() to avoid calling resume callback, so > jackpoll was used to really power up the codec. > > We can use direct-complete to do the keep the codec suspended throughout > the system PM flow, namely, keep the codec suspended all the way, unless > the codec needs to be woken up after resume. > > For HDA controller, PCI core may enable direct-complete for it if > conditions are met. So make runtime and system PM distinctive to always > apply correct wake up setting. > > At least point, hopefully all runtime PM issues are solved, let's enable > runtime PM by default again. > > v3: > - Drop "ALSA: hda: Stop mangling PCI IRQ" > > Kai-Heng Feng (3): > ALSA: hda: Refactor codec PM to use direct-complete optimization > ALSA: hda: Separate runtime and system suspend > ALSA: hda: Reinstate runtime_allow() for all hda controllers Now I applied all three patches. Since it's a nice improvement, I'm going to push to 5.10. thanks, Takashi