From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AFE2C07E85 for ; Tue, 11 Dec 2018 10:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A18E120849 for ; Tue, 11 Dec 2018 10:28:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A18E120849 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726249AbeLKK2A (ORCPT ); Tue, 11 Dec 2018 05:28:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:57474 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726114AbeLKK17 (ORCPT ); Tue, 11 Dec 2018 05:27:59 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id EBBCAAD52; Tue, 11 Dec 2018 10:27:56 +0000 (UTC) Date: Tue, 11 Dec 2018 11:27:56 +0100 Message-ID: From: Takashi Iwai To: "Andy Shevchenko" Cc: "Ayman Bagabas" , "ALSA Development Mailing List" , "Hui Wang" , "Andy Shevchenko" , "Darren Hart" , "Jaroslav Kysela" , "Kailang Yang" , "Linux Kernel Mailing List" , "Platform Driver" Subject: Re: [PATCH v10 3/3] ALSA: hda: add support for Huawei WMI micmute LED In-Reply-To: References: <20181211060125.28671-1-ayman.bagabas@gmail.com> <20181211060125.28671-4-ayman.bagabas@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/26 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 11 Dec 2018 11:09:59 +0100, Andy Shevchenko wrote: > > On Tue, Dec 11, 2018 at 8:02 AM Ayman Bagabas wrote: > > > > Some of Huawei laptops come with a LED in the micmute key. This patch > > enables the use of micmute LED for these devices: > > 1. Matebook X (19e5:3200), (19e5:3201) > > 2. Matebook X Pro (19e5:3204) > > > > Reviewed-by: Takashi Iwai > > Signed-off-by: Ayman Bagabas > > --- > > sound/pci/hda/patch_realtek.c | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > > index 1326f32f4574..9766fd249bdf 100644 > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -5776,7 +5776,9 @@ static const struct hda_fixup alc269_fixups[] = { > > {0x1e, 0x411111f0}, > > {0x21, 0x04211020}, > > { } > > > - } > > + }, > > This is not related change, but we may fix it when applying. > > > + .chained = true, > > + .chain_id = ALC255_FIXUP_MIC_MUTE_LED The comma is needed only because you add more fields. So this isn't wrong, per se. OTOH, you can avoid this extra change if you already had a comma in the first patch, yeah. thanks, Takashi