From: Takashi Iwai <tiwai@suse.de>
To: "Sebastian Reichel" <sebastian.reichel@collabora.co.uk>
Cc: "Tony Lindgren" <tony@atomide.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
<alsa-devel@alsa-project.org>, "Jaroslav Kysela" <perex@perex.cz>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCHv2 3/6] ASoC: codec: cpcap: new codec
Date: Wed, 12 Jul 2017 17:37:38 +0200 [thread overview]
Message-ID: <s5h1splk6nx.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170712151846.24621-4-sebastian.reichel@collabora.co.uk>
On Wed, 12 Jul 2017 17:18:43 +0200,
Sebastian Reichel wrote:
>
> +/* Capture Gain Control: 0dB to 31dB in 1dB steps */
> +static DECLARE_TLV_DB_SCALE(mic_gain_tlv, 0, 100, 0);
> +
> +/* Playback Gain Control: -33dB to 12dB in 3dB steps */
> +static DECLARE_TLV_DB_SCALE(vol_tlv, -3300, 300, 0);
Better to set const for TLV declarations here...
> +static const char * const cpcap_phase_invert_texts[] = {
> + "Non Inverted", "Inverted"
> +};
> +static const SOC_ENUM_SINGLE_DECL(cpcap_hifi_l_phase_inv_enum,
> + CPCAP_REG_RXSDOA, CPCAP_BIT_MONO_DAC0, cpcap_phase_invert_texts);
> +static const SOC_ENUM_SINGLE_DECL(cpcap_ext_l_phase_inv_enum,
> + CPCAP_REG_RXEPOA, CPCAP_BIT_MONO_EXT0, cpcap_phase_invert_texts);
... while SOC_ENUM_*_DECL() already contain const, so you should omit
const here.
thanks,
Takashi
next prev parent reply other threads:[~2017-07-12 15:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-12 15:18 [PATCHv2 0/6] Motorola Droid 4 Audio Support Sebastian Reichel
2017-07-12 15:18 ` [PATCHv2 1/6] ALSA: pcm: Export soc_dpcm_runtime_update Sebastian Reichel
2017-07-12 15:18 ` [PATCHv2 2/6] dt-bindings: sound: add motorola,cpcap-audio-codec Sebastian Reichel
2017-07-12 15:18 ` [PATCHv2 3/6] ASoC: codec: cpcap: new codec Sebastian Reichel
2017-07-12 15:37 ` Takashi Iwai [this message]
2017-07-17 9:29 ` Tony Lindgren
2017-07-17 14:18 ` Sebastian Reichel
2017-07-17 15:21 ` Mark Brown
2017-07-12 15:18 ` [PATCHv2 4/6] ARM: dts: motorola-cpcap-mapphone: add audio-codec Sebastian Reichel
2017-07-12 15:18 ` [PATCHv2 5/6] ARM: dts: motorola-cpcap-mapphone: set initial mode for vaudio Sebastian Reichel
2017-07-12 15:18 ` [PATCHv2 6/6] ARM: dts: omap4-droid4: add soundcard Sebastian Reichel
2017-07-17 9:29 ` [PATCHv2 0/6] Motorola Droid 4 Audio Support Tony Lindgren
2017-07-17 10:12 ` Sebastian Reichel
2017-07-17 10:17 ` Tony Lindgren
2017-07-17 14:13 ` Sebastian Reichel
2017-07-18 5:48 ` Tony Lindgren
2017-07-18 9:29 ` Sebastian Reichel
2017-07-18 9:37 ` Takashi Iwai
2017-07-27 9:39 ` Tony Lindgren
2017-07-27 10:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1splk6nx.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®