From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755277AbcHVNNM (ORCPT ); Mon, 22 Aug 2016 09:13:12 -0400 Received: from mx2.suse.de ([195.135.220.15]:56685 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbcHVNNL (ORCPT ); Mon, 22 Aug 2016 09:13:11 -0400 Date: Mon, 22 Aug 2016 15:13:09 +0200 Message-ID: From: Takashi Iwai To: "Nicolas Iooss" Cc: "Jaroslav Kysela" , Subject: Re: [PATCH 1/1] ASoc: simple-card-utils: add __printf attribute In-Reply-To: <7bb40eff-d1ae-4739-0396-6f24089416f5@m4x.org> References: <20160806095837.25885-1-nicolas.iooss_linux@m4x.org> <7bb40eff-d1ae-4739-0396-6f24089416f5@m4x.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 22 Aug 2016 15:06:05 +0200, Nicolas Iooss wrote: > > Hello, > > After I sent the following patch a few weeks ago, I have not received > any feedback. Could you please review it? This is about ASoC, so please resubmit to alsa-devel ML with Cc to the ASoC maintainer (Mark) and the author of the code (Morimoto-san). Also, please use the correct prefix "ASoC" in the subject line. thanks, Takashi > > Thanks, > Nicolas > > On 06/08/16 11:58, Nicolas Iooss wrote: > > asoc_simple_card_set_dailink_name() uses devm_kvasprintf() to format > > some of its arguments. Adding a __printf attribute to this function > > makes it possible to detect at compile-time errors related to format > > strings. > > > > Signed-off-by: Nicolas Iooss > > --- > > include/sound/simple_card_utils.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/sound/simple_card_utils.h b/include/sound/simple_card_utils.h > > index 86088aed9002..3207b1a70d38 100644 > > --- a/include/sound/simple_card_utils.h > > +++ b/include/sound/simple_card_utils.h > > @@ -27,6 +27,7 @@ int asoc_simple_card_parse_daifmt(struct device *dev, > > struct device_node *codec, > > char *prefix, > > unsigned int *retfmt); > > +__printf(3, 4) > > int asoc_simple_card_set_dailink_name(struct device *dev, > > struct snd_soc_dai_link *dai_link, > > const char *fmt, ...); > > > >