From: Takashi Iwai <tiwai@suse.de>
To: "Christophe JAILLET" <christophe.jaillet@wanadoo.fr>
Cc: <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: echoaudio: Fix memory allocation
Date: Mon, 27 Jun 2016 22:28:23 +0200 [thread overview]
Message-ID: <s5h1t3iwf4o.wl-tiwai@suse.de> (raw)
In-Reply-To: <1467054411-19752-1-git-send-email-christophe.jaillet@wanadoo.fr>
On Mon, 27 Jun 2016 21:06:51 +0200,
Christophe JAILLET wrote:
>
> 'commpage_bak' is allocated with 'sizeof(struct echoaudio)' bytes.
> We then copy 'sizeof(struct comm_page)' bytes in it.
> On my system, smatch complains because one is 2960 and the other is 3072.
>
> This would result in memory corruption or a oops.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied, thanks.
Takashi
next prev parent reply other threads:[~2016-06-27 20:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-27 19:06 Christophe JAILLET
2016-06-27 20:28 ` Takashi Iwai [this message]
2016-06-28 7:13 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1t3iwf4o.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®