From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752481AbcA2GdO (ORCPT ); Fri, 29 Jan 2016 01:33:14 -0500 Received: from mx2.suse.de ([195.135.220.15]:53271 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751717AbcA2GdN (ORCPT ); Fri, 29 Jan 2016 01:33:13 -0500 Date: Fri, 29 Jan 2016 07:33:11 +0100 Message-ID: From: Takashi Iwai To: "Insu Yun" Cc: , , , , , , , , , Subject: Re: [PATCH] emu10k1: correctly handling failed thread creation In-Reply-To: <1454025097-13153-1-git-send-email-wuninsu@gmail.com> References: <1454025097-13153-1-git-send-email-wuninsu@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Jan 2016 00:51:37 +0100, Insu Yun wrote: > > Since kthread_create can be failed, it needs to check > whether error occurred and return error code. > > Signed-off-by: Insu Yun > --- > sound/pci/emu10k1/emu10k1_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/sound/pci/emu10k1/emu10k1_main.c b/sound/pci/emu10k1/emu10k1_main.c > index 28e2f8b..b9eac15 100644 > --- a/sound/pci/emu10k1/emu10k1_main.c > +++ b/sound/pci/emu10k1/emu10k1_main.c > @@ -1141,6 +1141,12 @@ static int snd_emu10k1_emu1010_init(struct snd_emu10k1 *emu) > emu->emu1010.firmware_thread = > kthread_create(emu1010_firmware_thread, emu, > "emu1010_firmware"); > + if (IS_ERR(emu->emu1010.firmware_thread)) { > + dev_info(emu->card->dev, > + "emu1010: Creating thread failed\n"); > + return PTR_ERR(emu->emu1010.firmware_thread); It needs to NULL-clear emu->emu1010.firmware_thread after this, since kthread_stop() is called for non-NULL case in the destructor. Could you fix it and resubmit? thanks, Takashi > + } > + > wake_up_process(emu->emu1010.firmware_thread); > } > > -- > 1.9.1 > >