From: Takashi Iwai <tiwai@suse.de>
To: Ondrej Zary <linux@rainbow-software.org>
Cc: Massimo Piccioni <dafastidio@libero.it>,
alsa-devel@alsa-project.org,
Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCH] snd-als100: fix suspend/resume
Date: Tue, 21 Aug 2012 10:00:45 +0200 [thread overview]
Message-ID: <s5h1uj08yj6.wl%tiwai@suse.de> (raw)
In-Reply-To: <201208202150.13593.linux@rainbow-software.org>
At Mon, 20 Aug 2012 21:50:13 +0200,
Ondrej Zary wrote:
>
> snd_card_als100_probe() does not set pcm field in struct snd_sb.
> As a result, PCM is not suspended and applications don't know that they need
> to resume the playback.
>
> Tested with Labway A381-F20 card (ALS120).
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
Applied now. Thanks.
Takashi
>
> --- a/sound/isa/als100.c
> +++ b/sound/isa/als100.c
> @@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
> irq[dev], dma8[dev], dma16[dev]);
> }
>
> - if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
> + if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
> snd_card_free(card);
> return error;
> }
>
>
>
>
> --
> Ondrej Zary
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2012-08-21 8:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-20 19:50 Ondrej Zary
2012-08-21 8:00 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1uj08yj6.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=dafastidio@libero.it \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rainbow-software.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®