From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931Ab1HHIW2 (ORCPT ); Mon, 8 Aug 2011 04:22:28 -0400 Received: from cantor2.suse.de ([195.135.220.15]:57527 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583Ab1HHIWZ (ORCPT ); Mon, 8 Aug 2011 04:22:25 -0400 Date: Mon, 08 Aug 2011 10:22:23 +0200 Message-ID: From: Takashi Iwai To: stufever@gmail.com Cc: linux-kernel@vger.kernel.org, perex@perex.cz, Wang Shaoyan Subject: Re: [PATCH] sound: don't use the deprecated function check_region In-Reply-To: <1312790832-6790-1-git-send-email-wangshaoyan.pt@taobao.com> References: <1312790832-6790-1-git-send-email-wangshaoyan.pt@taobao.com> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Mon, 8 Aug 2011 16:07:12 +0800, stufever@gmail.com wrote: > > From: Wang Shaoyan > > sound/oss/pss.c: In function 'configure_nonsound_components': > sound/oss/pss.c:676: warning: 'check_region' is deprecated (declared at include/linux/ioport.h:201) > > Signed-off-by: Wang Shaoyan > --- > sound/oss/pss.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/sound/oss/pss.c b/sound/oss/pss.c > index 9b800ce..0fa26bd 100644 > --- a/sound/oss/pss.c > +++ b/sound/oss/pss.c > @@ -673,9 +673,10 @@ static void configure_nonsound_components(void) > > if (pss_cdrom_port == -1) { /* If cdrom port enablation wasn't requested */ > printk(KERN_INFO "PSS: CDROM port not enabled.\n"); > - } else if (check_region(pss_cdrom_port, 2)) { > + } else if (!request_region(pss_cdrom_port, 2, "PSS CDROM")) { > printk(KERN_ERR "PSS: CDROM I/O port conflict.\n"); > } else { > + release_region(pss_cdrom_port, 2); > set_io_base(devc, CONF_CDROM, pss_cdrom_port); > printk(KERN_INFO "PSS: CDROM I/O port set to 0x%x.\n", pss_cdrom_port); > } Well, this just hides the warning but doesn't fix the possible race, which is the reason check_region() is marked as deprecated after all. Instead of releasing the resource there, keep it and release in the destructor properly like other normal resources. thanks, Takashi