mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Jeffrin Jose <ahiliation@yahoo.co.in>
Cc: Jaroslav Kysela <perex@perex.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: sound: Fixed line limit issue in sound/ac97_bus.c
Date: Mon, 06 Dec 2010 16:12:44 +0100	[thread overview]
Message-ID: <s5h1v5vue8j.wl%tiwai@suse.de> (raw)
In-Reply-To: <20101206150724.GA2752@debian.Jeff>

At Mon, 6 Dec 2010 20:37:24 +0530,
Jeffrin Jose wrote:
> 
> hello.
> a small patch for a format issue is attached with this
> mail.

Thanks for the patch.

I applied it now, but had to fix a few things manually:
 - A blank line is necessary between the patch subject and the
   changelog text; otherwise git-am will be confused
 - You don't have to indent the change text
 - Align the closing comment "*/"


Takashi

> -- 
> software engineer.
> department of computer science
> rajagiri school of engineering and technology.
> [2 0001-sound-Fixed-line-limit-issue-in-sound-ac97_bus.c.patch <text/x-diff; us-ascii (7bit)>]
> >From a2c2867876c246420a199a0fb4c36ad2965a42cc Mon Sep 17 00:00:00 2001
> From: Jeffrin Jose <ahiliation@yahoo.co.in>
> Date: Mon, 6 Dec 2010 19:27:53 +0530
> Subject: [PATCH] sound: Fixed line limit issue in sound/ac97_bus.c
>  This is a patch to the sound/ac97_bus.c file that fixes up a 80 character
>  line limit issue found by the checkpatch.pl tool.
>  Signed-off-by: Jeffrin Jose <ahiliation@yahoo.co.in>
> 
> ---
>  sound/ac97_bus.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/ac97_bus.c b/sound/ac97_bus.c
> index a351dd0..c93251a 100644
> --- a/sound/ac97_bus.c
> +++ b/sound/ac97_bus.c
> @@ -19,9 +19,9 @@
>  
>  /*
>   * Let drivers decide whether they want to support given codec from their
> - * probe method.  Drivers have direct access to the struct snd_ac97 structure and may
> - * decide based on the id field amongst other things.
> - */
> + * probe method. Drivers have direct access to the struct snd_ac97
> + * structure and may  decide based on the id field amongst other things.
> +*/
>  static int ac97_bus_match(struct device *dev, struct device_driver *drv)
>  {
>  	return 1;
> -- 
> 1.7.1
> 

      reply	other threads:[~2010-12-06 15:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06 15:07 Jeffrin Jose
2010-12-06 15:12 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1v5vue8j.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=ahiliation@yahoo.co.in \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®