mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Chris Ball <cjb@laptop.org>
Cc: Philip Rakity <prakity@marvell.com>,
	linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Aries Lee <arieslee@jmicron.com>
Subject: Re: [PATCH 2/2] mmc: Test bus-width for old MMC devices
Date: Sun, 05 Dec 2010 11:50:40 +0100	[thread overview]
Message-ID: <s5h1v5wv6gv.wl%tiwai@suse.de> (raw)
In-Reply-To: <20101205040221.GA24547@void.printf.net>

Hi Chris,

At Sun, 5 Dec 2010 04:02:24 +0000,
Chris Ball wrote:
> 
> Hi Takashi, Philip,
> 
> On Wed, Nov 24, 2010 at 07:21:14AM +0100, Takashi Iwai wrote:
> > From: Aries Lee <arieslee@jmicron.com>
> > 
> > Some old MMC devices fail with the 4/8 bits the driver tries to use
> > exclusively.  This patch adds a test for the given bus setup and falls
> > back to the lower bit mode (until 1-bit mode) when the test fails.
> > 
> > [Major rework and refactoring by tiwai]
> > 
> > Signed-off-by: Aries Lee <arieslee@jmicron.com>
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> We have two independent patches for performing MMC bus-width testing now:
> 
>   https://patchwork.kernel.org/patch/351781/
>   https://patchwork.kernel.org/patch/361702/

Yeah, Philip and I discussed shortly in a mail thread after that.

> I'm planning on taking Takashi's since it looks a little cleaner; Philip,
> please could you take a look at Takashi's patch and add anything you
> think should be present from your own patch as a new incremental patch?

One missing thing in my (originally Aries') patch is the quirk bit to
enable/disable the bus-width test.  In Philip's latest patch, the
default is off.

I'm also not sure whether this bus-width test should be enabled as
default.  I guess it's better for performance, so I'd vote for turning
on as default.  But, having a quirk for turning off would be safer for
working around old hardware problems, of course.


thanks,

Takashi

  reply	other threads:[~2010-12-05 10:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-24  6:21 [PATCH 0/2] mmc: Add support for JMicron 388 SD/MMC controller Takashi Iwai
2010-11-24  6:21 ` [PATCH 1/2] " Takashi Iwai
2010-11-24  9:59   ` Wolfram Sang
2010-11-24 11:29     ` Takashi Iwai
2010-11-24 22:04       ` Wolfram Sang
2010-12-07 16:14         ` Takashi Iwai
2010-11-24  6:21 ` [PATCH 2/2] mmc: Test bus-width for old MMC devices Takashi Iwai
2010-12-05  4:02   ` Chris Ball
2010-12-05 10:50     ` Takashi Iwai [this message]
2010-12-05 18:40       ` Chris Ball
2010-12-06  1:53         ` Philip Rakity
2010-12-15  4:03   ` zhangfei gao
2010-12-15  6:41     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1v5wv6gv.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=arieslee@jmicron.com \
    --cc=cjb@laptop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=prakity@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®