From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754357Ab0J0HNj (ORCPT ); Wed, 27 Oct 2010 03:13:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38259 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753783Ab0J0HNg (ORCPT ); Wed, 27 Oct 2010 03:13:36 -0400 Date: Wed, 27 Oct 2010 09:13:35 +0200 Message-ID: From: Takashi Iwai To: Julia Lawall Cc: Jaroslav Kysela , kernel-janitors@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 9/14] sound/oss/sb_ess.c: delete double assignment In-Reply-To: <1288088743-3725-10-git-send-email-julia@diku.dk> References: <1288088743-3725-1-git-send-email-julia@diku.dk> <1288088743-3725-10-git-send-email-julia@diku.dk> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Oct 2010 12:25:38 +0200, Julia Lawall wrote: > > From: Julia Lawall > > Delete successive assignments to the same location. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > expression i; > @@ > > *i = ...; > i = ...; > // > > Signed-off-by: Julia Lawall Thanks, applied now. Takashi > --- > sound/oss/sb_ess.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/oss/sb_ess.c b/sound/oss/sb_ess.c > index 51a3d38..9890cf2 100644 > --- a/sound/oss/sb_ess.c > +++ b/sound/oss/sb_ess.c > @@ -1722,7 +1722,6 @@ printk (KERN_INFO "FKS: es_rec_set_recmask mask = %x\n", mask); > right = (value & 0x0000ff00) >> 8; > } else { /* Turn it off (3) */ > left = 0; > - left = 0; > right = 0; > } > sb_common_mixer_set(devc, i + ES_REC_MIXER_RECDIFF, left, right); >