From: Takashi Iwai <tiwai@suse.de>
To: Julia Lawall <julia@diku.dk>
Cc: Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/20] sound/pci/asihpi: Use kzalloc
Date: Mon, 17 May 2010 08:15:08 +0200 [thread overview]
Message-ID: <s5h1vdbuk9f.wl%tiwai@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1005132157400.6282@ask.diku.dk>
At Thu, 13 May 2010 21:58:37 +0200 (CEST),
Julia Lawall wrote:
>
> From: Julia Lawall <julia@diku.dk>
>
> Use kzalloc rather than the combination of kmalloc and memset.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
>
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
> if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied now. Thanks.
Takashi
> ---
> sound/pci/asihpi/hpi6000.c | 3 +--
> sound/pci/asihpi/hpi6205.c | 3 +--
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff -u -p a/sound/pci/asihpi/hpi6000.c b/sound/pci/asihpi/hpi6000.c
> --- a/sound/pci/asihpi/hpi6000.c
> +++ b/sound/pci/asihpi/hpi6000.c
> @@ -448,14 +448,13 @@ static void subsys_create_adapter(struct
> if (phm->u.s.resource.r.pci->device_id != HPI_PCI_DEV_ID_PCI2040)
> return;
>
> - ao.priv = kmalloc(sizeof(struct hpi_hw_obj), GFP_KERNEL);
> + ao.priv = kzalloc(sizeof(struct hpi_hw_obj), GFP_KERNEL);
> if (!ao.priv) {
> HPI_DEBUG_LOG(ERROR, "cant get mem for adapter object\n");
> phr->error = HPI_ERROR_MEMORY_ALLOC;
> return;
> }
>
> - memset(ao.priv, 0, sizeof(struct hpi_hw_obj));
> /* create the adapter object based on the resource information */
> /*? memcpy(&ao.Pci,&phm->u.s.Resource.r.Pci,sizeof(ao.Pci)); */
> ao.pci = *phm->u.s.resource.r.pci;
> diff -u -p a/sound/pci/asihpi/hpi6205.c b/sound/pci/asihpi/hpi6205.c
> --- a/sound/pci/asihpi/hpi6205.c
> +++ b/sound/pci/asihpi/hpi6205.c
> @@ -482,13 +482,12 @@ static void subsys_create_adapter(struct
> if (phm->u.s.resource.r.pci->device_id != HPI_PCI_DEV_ID_DSP6205)
> return;
>
> - ao.priv = kmalloc(sizeof(struct hpi_hw_obj), GFP_KERNEL);
> + ao.priv = kzalloc(sizeof(struct hpi_hw_obj), GFP_KERNEL);
> if (!ao.priv) {
> HPI_DEBUG_LOG(ERROR, "cant get mem for adapter object\n");
> phr->error = HPI_ERROR_MEMORY_ALLOC;
> return;
> }
> - memset(ao.priv, 0, sizeof(struct hpi_hw_obj));
>
> ao.pci = *phm->u.s.resource.r.pci;
> err = create_adapter_obj(&ao, &os_error_code);
>
prev parent reply other threads:[~2010-05-17 6:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 19:58 Julia Lawall
2010-05-17 6:15 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h1vdbuk9f.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®