From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753563Ab0CDK4n (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Mar 2010 05:56:43 -0500
Received: from cantor.suse.de ([195.135.220.2]:47297 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751513Ab0CDK4m (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Mar 2010 05:56:42 -0500
Date: Thu, 04 Mar 2010 11:56:40 +0100
Message-ID: <s5h1vg0qrrr.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Wei Ni <wni@nvidia.com>
Cc: "'Pavel Hofman'" <pavel.hofman@insite.cz>,
       "'alsa-devel'" <alsa-devel@alsa-project.org>,
       "'linux-kernel'" <linux-kernel@vger.kernel.org>,
       "'akpm'" <akpm@linux-foundation.org>
Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
In-Reply-To: <6B4D417B830BC44B8026029FD256F7F1C16B1AD554@HKMAIL01.nvidia.com>
References: <6B4D417B830BC44B8026029FD256F7F1C068B2BA8B@HKMAIL01.nvidia.com>
	<s5hmxyrp311.wl%tiwai@suse.de>
	<6B4D417B830BC44B8026029FD256F7F1C068B2BA8C@HKMAIL01.nvidia.com>
	<s5heik3ujy0.wl%tiwai@suse.de>
	<6B4D417B830BC44B8026029FD256F7F1C16A89A118@HKMAIL01.nvidia.com>
	<6B4D417B830BC44B8026029FD256F7F1C16A89A11A@HKMAIL01.nvidia.com>
	<s5haaupoqew.wl%tiwai@suse.de>
	<6B4D417B830BC44B8026029FD256F7F1C16A89A11C@HKMAIL01.nvidia.com>
	<s5htysxm5yo.wl%tiwai@suse.de>
	<6B4D417B830BC44B8026029FD256F7F1C16B1AD54C@HKMAIL01.nvidia.com>
	<s5hzl2ol8qu.wl%tiwai@suse.de>
	<6B4D417B830BC44B8026029FD256F7F1C16B1AD554@HKMAIL01.nvidia.com>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Thu, 4 Mar 2010 18:46:59 +0800,
Wei Ni wrote:
> 
> Hi, Takashi
> I think we can submit my patch first,

But your patch breaks the build when CONFIG_SND_HDA_*=y.
So, it should be fixed in your patch.


thanks,

Takashi

> then generate another patch
> to add EXPORT_SYMBOL() in hda_eld.c, and change Makefile to remove
> hda_eld.o from snd-hda-codec-xxhdmi-objs.
> 
> Thanks
> Wei.
> nvpublic
> 
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de] 
> Sent: Thursday, March 04, 2010 5:47 PM
> To: Wei Ni
> Cc: 'Pavel Hofman'; 'alsa-devel'; 'linux-kernel'; 'akpm'
> Subject: Re: [alsa-devel] [PATCH]Support MCP89 and GT21x hdmi audio
> 
> At Thu, 4 Mar 2010 10:21:39 +0800,
> Wei Ni wrote:
> > 
> > Hi, Takashi
> > 1. Yes, it can works for all Nvidia controller.
> 
> OK.
> 
> > 2. The hda_eld.o doesn't export any symbols.
> > I tried to put hda_eld.o to snd-had-codec-*, and remove had_eldo.o
> > from snd-had-codec-intelhdmi-objs, but it will build error. It need
> > to modify hda_eld.c to export symbols, it will add many changes.
> 
> Yes, this is unavoidable.  Please add EXPORT_SYMBOL()'s
> appropriately.
> 
> We can reduce them again once after all HDMI stuff is merged into
> one.
> 
> 
> thanks,
> 
> Takashi
>