From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761935AbZLPJOx (ORCPT ); Wed, 16 Dec 2009 04:14:53 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761902AbZLPJOu (ORCPT ); Wed, 16 Dec 2009 04:14:50 -0500 Received: from cantor.suse.de ([195.135.220.2]:43997 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761901AbZLPJOr (ORCPT ); Wed, 16 Dec 2009 04:14:47 -0500 Date: Wed, 16 Dec 2009 10:14:44 +0100 Message-ID: From: Takashi Iwai To: Dmitry Torokhov Cc: Alex Chiang , linux-kernel , linux-input@vger.kernel.org Subject: Re: synaptics touchpad doesn't click In-Reply-To: <20091216082020.GG2699@core.coreip.homeip.net> References: <20091215062628.GA12669@core.coreip.homeip.net> <20091215073358.GC12669@core.coreip.homeip.net> <20091215082518.GD12669@core.coreip.homeip.net> <20091216010506.GA26367@ldl.fc.hp.com> <20091216025934.GA2699@core.coreip.homeip.net> <20091216065200.GC20352@ldl.fc.hp.com> <20091216070343.GF2699@core.coreip.homeip.net> <20091216082020.GG2699@core.coreip.homeip.net> User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Wed, 16 Dec 2009 00:20:20 -0800, Dmitry Torokhov wrote: > > On Wed, Dec 16, 2009 at 08:11:05AM +0100, Takashi Iwai wrote: > > At Tue, 15 Dec 2009 23:03:43 -0800, > > Dmitry Torokhov wrote: > > > > > > On Tue, Dec 15, 2009 at 11:52:00PM -0700, Alex Chiang wrote: > > > > * Dmitry Torokhov : > > > > > On Tue, Dec 15, 2009 at 06:05:06PM -0700, Alex Chiang wrote: > > > > > > * Dmitry Torokhov : > > > > > > > > > > > > > > The updated patch is below. > > > > > > > > > > > > > > -- > > > > > > > Dmitry > > > > > > > > > > > > Should I test this one or wait one more iteration to address > > > > > > Takashi's last comments? > > > > > > > > > > > > > > > > Actually I think we took the wrong direction with the original patch and > > > > > we should do what other buttonless devices (bcm5974) do: report touchpad > > > > > click as left button and have Synaptics X driver provide enhanced > > > > > support. This way we can have both modes (ClickZones and ClickButtons) > > > > > and users will get to chose (provided that someone takes time to add > > > > > that support to Synaptics driver of course ;) ). > > > > > > > > > > Could you tell me if the below works for you? > > > > > > > > Left clicks work. Right/middle do not (as expected, I guess). > > > > > > > > I liked the behaviour of Takashi's patch a little better wrt what > > > > happens when you try to click/drag, because he disabled movement > > > > in the click area. > > > > > > Are the clicks register only in that special area? Reading Synaptics > > > product description it sounds like entire surface should be clickable. > > > > In the case of ClickZone, the click in the button area is taken as > > clicks, if I understand correctly. > > > > The problem is, however, not about where to click. It's about the > > precision. When you click a pad, your finger slips a little bit in > > millimeter. This already corresponds to a few pixels, and the pointer > > moves away from the point you wanted to click. > > > > Right, this will have to be dealt with in X driver. > > > In my original patch, I disabled the pointer movement in the button > > area before click for avoiding this problem. > > > > However it will not work if you want to do 'ClickButtons' mode where > you don't assign secific areas for clicking. Yes. And the area is more or less fixed. Takashi