From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756502AbYHZFgB (ORCPT ); Tue, 26 Aug 2008 01:36:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752073AbYHZFfx (ORCPT ); Tue, 26 Aug 2008 01:35:53 -0400 Received: from cantor.suse.de ([195.135.220.2]:41070 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752002AbYHZFfw (ORCPT ); Tue, 26 Aug 2008 01:35:52 -0400 Date: Tue, 26 Aug 2008 07:35:51 +0200 Message-ID: From: Takashi Iwai To: "Tony Luck" Cc: "Linus Torvalds" , "Andrew Morton" , linux-kernel@vger.kernel.org Subject: Re: [GIT PULL] ALSA fixes for 2.6.27-rc4 In-Reply-To: References: <12c511ca0808251420r10957a7v423644003377a6ec@mail.gmail.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Tue, 26 Aug 2008 07:22:42 +0200, I wrote: > > At Mon, 25 Aug 2008 14:20:07 -0700, > Tony Luck wrote: > > > > On Mon, Aug 25, 2008 at 10:01 AM, Takashi Iwai wrote: > > > --- a/sound/pci/ca0106/ca0106_main.c > > > +++ b/sound/pci/ca0106/ca0106_main.c > > > @@ -249,11 +249,12 @@ static struct snd_ca0106_details ca0106_chip_details[] = { > > > .name = "MSI K8N Diamond MB [SB0438]", > > > .gpio_type = 2, > > > .i2c_adc = 1 } , > > > - /* Another MSI K8N Diamond MB, which has apprently a different SSID */ > > > + /* MSI K8N Diamond PLUS MB */ > > > { .serial = 0x10091102, > > > .name = "MSI K8N Diamond MB", > > > .gpio_type = 2, > > > - .i2c_adc = 1 } , > > > + .i2c_adc = 1, > > > + .spi_dac = 2 } > > > > Missing "," on this line is causing build failure here. > > Yep, sorry, I propagated a wrong patch upward. > Will do a pull-request of the fixed patch soon. ... and it was already fixed by Stephen's patch. Thanks! Takashi