From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1750827AbWDSJeA@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1750827AbWDSJeA (ORCPT <rfc822;willy@w.ods.org>);
	Wed, 19 Apr 2006 05:34:00 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750830AbWDSJeA
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 19 Apr 2006 05:34:00 -0400
Received: from mx2.suse.de ([195.135.220.15]:23759 "EHLO mx2.suse.de")
	by vger.kernel.org with ESMTP id S1750827AbWDSJeA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 19 Apr 2006 05:34:00 -0400
Date: Wed, 19 Apr 2006 11:33:58 +0200
Message-ID: <s5h1wvtvri1.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: "Jon Masters" <jonathan@jonmasters.org>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sound: fix hang in mpu401_uart.c
In-Reply-To: <35fb2e590604181645h32107d4fma13ddd8c7649bc13@mail.gmail.com>
References: <20060416031235.GA6741@apogee.jonmasters.org>
	<s5hbquzxbsm.wl%tiwai@suse.de>
	<35fb2e590604181645h32107d4fma13ddd8c7649bc13@mail.gmail.com>
User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta25)
 (eggplant) (+CVS-20060326) (i386-suse-linux)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

At Wed, 19 Apr 2006 00:45:14 +0100,
Jon Masters wrote:
> 
> On 4/18/06, Takashi Iwai <tiwai@suse.de> wrote:
> 
> > > +             if ((err = snd_mpu401_uart_cmd(mpu, MPU401_RESET, 1))) {
> > > +                     return -EFAULT;
> >
> > IMO, -EFAULT isn't a good choice for this kind of error.
> 
> What would you suggest?

I would use -EIO.


Takashi