From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422660AbWAMNPb (ORCPT ); Fri, 13 Jan 2006 08:15:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030278AbWAMNPb (ORCPT ); Fri, 13 Jan 2006 08:15:31 -0500 Received: from cantor2.suse.de ([195.135.220.15]:54682 "EHLO mx2.suse.de") by vger.kernel.org with ESMTP id S1030322AbWAMNPa (ORCPT ); Fri, 13 Jan 2006 08:15:30 -0500 Date: Fri, 13 Jan 2006 14:21:27 +0100 Message-ID: From: Takashi Iwai To: Jon Mason Cc: linux-kernel@vger.kernel.org, Jiri Slaby , mulix@mulix.org, Jaroslav Kysela , audio@tridentmicro.com Subject: Re: [PATCH] Prevent ALSA trident driver from grabbing pcnet32 hardware In-Reply-To: <20060112220530.GF17539@us.ibm.com> References: <20060112220530.GF17539@us.ibm.com> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 MULE XEmacs/21.5 (beta21) (corn) (+CVS-20050720) (i386-suse-linux) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 12 Jan 2006 16:05:30 -0600, Jon Mason wrote: > > Some pcnet32 hardware erroneously has the Vendor ID for Trident. The > pcnet32 driver looks for the PCI ethernet class before grabbing the > hardware, but the current trident driver does not check against the > PCI audio class. This allows the trident driver to claim the pcnet32 > hardware. This patch prevents that. > > Per Jiri Slaby's request, I changed the trident driver to use > PCI_DEVICE macro and PCI ID #defines. > > This patch is untested on Trident 4DWAVE_DX hardware, but has been > tested on pcnet32 hardware. > > Thanks, > Jon > > Signed-off-by: Jon Mason Applied to ALSA tree. Thanks. Takashi