From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 7C802C4332F
	for <linux-kernel@archiver.kernel.org>; Wed,  9 Feb 2022 07:09:31 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236092AbiBIHJ0 (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 9 Feb 2022 02:09:26 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36814 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S234655AbiBIHJW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 9 Feb 2022 02:09:22 -0500
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 567D6C0613CB;
        Tue,  8 Feb 2022 23:09:26 -0800 (PST)
Received: from relay2.suse.de (relay2.suse.de [149.44.160.134])
        by smtp-out1.suse.de (Postfix) with ESMTP id 11579210F1;
        Wed,  9 Feb 2022 07:09:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
        t=1644390565; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=dittJlgPCXfXnSmHz5MOmE4VVHrmBCwHv/MXR6K2oV4=;
        b=JaP2Zh/LA/wjDxFE4rsruNMjkRWQuk7rBlrhGpidQT6jX74Jj+Uua9rQEODw+7T6W/W6bB
        v8Z9lpbClCH2OfwSVG9hWcoDvwJuYRdWeOmuOE/ytNJ8rZoOHTzPpJGPCJBkau3r08DeCz
        octIdMx/jpGQUap8raIq5GbylNHObxk=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
        s=susede2_ed25519; t=1644390565;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=dittJlgPCXfXnSmHz5MOmE4VVHrmBCwHv/MXR6K2oV4=;
        b=LfpkBgsbMjb5KtjkiOTt9e8OmTulhzudS4tSlrLG4DotaelaMRCZBvWA4rLUDaJPBYQrtm
        7ImaZLoskAzxCyBQ==
Received: from alsa1.suse.de (alsa1.suse.de [10.160.4.42])
        by relay2.suse.de (Postfix) with ESMTP id 03363A3B83;
        Wed,  9 Feb 2022 07:09:25 +0000 (UTC)
Date:   Wed, 09 Feb 2022 08:09:24 +0100
Message-ID: <s5h35ksqzx7.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Mohan Kumar <mkumard@nvidia.com>
Cc:     <broonie@kernel.org>, <lgirdwood@gmail.com>, <robh+dt@kernel.org>,
        <thierry.reding@gmail.com>, <tiwai@suse.com>,
        <jonathanh@nvidia.com>, <spujar@nvidia.com>,
        <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 3/6] ALSA: hda/tegra: Update scratch reg. communication
In-Reply-To: <20220209042326.15764-4-mkumard@nvidia.com>
References: <20220209042326.15764-1-mkumard@nvidia.com>
        <20220209042326.15764-4-mkumard@nvidia.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 09 Feb 2022 05:23:23 +0100,
Mohan Kumar wrote:
> 
> --- a/include/sound/hda_codec.h
> +++ b/include/sound/hda_codec.h
> @@ -240,6 +240,10 @@ struct hda_codec {
>  	unsigned int single_adc_amp:1; /* adc in-amp takes no index
>  					* (e.g. CX20549 codec)
>  					*/
> +	unsigned int hdmi_intr_trig_ctrl:1; /* hdmi interrupt trigger
> +					     * control flag
> +					     * (e.g. Nvidia codecs)
> +					     */

This flag is specific to (Nvidia) HDMI codec and referred only from
patch_hdmi.c, right?  If so, the flag would be better put locally to
struct hdmi_spec instead of a global hda_codec.


thanks,

Takashi