From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFB5C433E6 for ; Thu, 28 Jan 2021 08:21:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E7AF64DD1 for ; Thu, 28 Jan 2021 08:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231865AbhA1IV2 (ORCPT ); Thu, 28 Jan 2021 03:21:28 -0500 Received: from mx2.suse.de ([195.135.220.15]:44112 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231725AbhA1IUk (ORCPT ); Thu, 28 Jan 2021 03:20:40 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7C593AEDA; Thu, 28 Jan 2021 08:19:58 +0000 (UTC) Date: Thu, 28 Jan 2021 09:19:58 +0100 Message-ID: From: Takashi Iwai To: Kai-Heng Feng Cc: "Rafael J. Wysocki" , "Kenneth R . Crudup" , Pavel Machek , Len Brown , Greg Kroah-Hartman , "open list:HIBERNATION (aka Software Suspend, aka swsusp)" , open list Subject: Re: [PATCH] PM: sleep: core: Resume suspended device if direct-complete is disabled In-Reply-To: References: <20201231060319.137133-1-kai.heng.feng@canonical.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jan 2021 09:15:10 +0100, Kai-Heng Feng wrote: > > On Thu, Jan 28, 2021 at 4:09 PM Takashi Iwai wrote: > > > > On Thu, 31 Dec 2020 07:03:19 +0100, > > Kai-Heng Feng wrote: > > > > > > HDA controller can't be runtime-suspended after commit 215a22ed31a1 > > > ("ALSA: hda: Refactor codjc PM to use direct-complete optimization"), > > > which enables direct-complete for HDA codec. > > > > > > The HDA codec driver doesn't expect direct-complete will be disabled > > > after it returns a positive value from prepare() callback. So freeze() > > > is called directly when it's runtime-suspended, breaks the balance of > > > its internal codec_powered counting. > > > > > > So if a device is prepared for direct-complete but PM core breaks the > > > assumption, resume the device to keep PM operations balanced. > > > > > > Fixes: 215a22ed31a1 ("ALSA: hda: Refactor codec PM to use direct-complete optimization") > > > Signed-off-by: Kai-Heng Feng > > > > Kai-Heng, is this fix still needed for 5.11? > > No it's not needed anymore because "ALSA: hda: Balance runtime/system > PM if direct-complete is disabled" is in place. > > > > > The description mentions about HD-audio controller, while the recent > > revert was the HD-audio codec, so I suppose it's still affected? > > Not affected anymore if above mentioned patch is applied. OK, thanks for clarification! Takashi