mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Dennis Wassenberg" <dennis.wassenberg@secunet.com>
Cc: "Hui Wang" <hui.wang@canonical.com>,
	"Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] hda: realtek: Make dock sound work on ThinkPad L570
Date: Thu, 08 Mar 2018 13:57:29 +0100	[thread overview]
Message-ID: <s5h371a913a.wl-tiwai@suse.de> (raw)
In-Reply-To: <46c65214-2a41-77ce-6484-979b08fc44c1@secunet.com>

On Thu, 08 Mar 2018 13:17:54 +0100,
Dennis Wassenberg wrote:
> 
> One version of Lenovo Thinkpad T570 did not use ALC298
> (like other Kaby Lake devices). Instead it uses ALC292.
> In order to make the Lenovo dock working with that codec
> the dock quirk for ALC292 will be used.
> 
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>

So, although the PCI SSID appears to be a new one, this still needs
the old quirk, not for T470 dock?  Just to be sure.


thanks,

Takashi

> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index b9c93fa..b5d0f8c 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -6508,6 +6508,7 @@ enum {
>  	SND_PCI_QUIRK(0x17aa, 0x2245, "Thinkpad T470", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2246, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x2247, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> +	SND_PCI_QUIRK(0x17aa, 0x2249, "Thinkpad", ALC292_FIXUP_TPT460),
>  	SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
>  	SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> -- 
> 1.9.1
> 
> 
> 

  reply	other threads:[~2018-03-08 12:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 12:17 Dennis Wassenberg
2018-03-08 12:57 ` Takashi Iwai [this message]
2018-03-08 13:13   ` Dennis Wassenberg
2018-03-08 13:34     ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h371a913a.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dennis.wassenberg@secunet.com \
    --cc=hui.wang@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®