From: Takashi Iwai <tiwai@suse.de>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Jaroslav Kysela" <perex@perex.cz>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda/ca0132 - fix possible NULL pointer use
Date: Wed, 11 Jan 2017 17:26:42 +0100 [thread overview]
Message-ID: <s5h37gpy33x.wl-tiwai@suse.de> (raw)
In-Reply-To: <20170111134013.3798733-1-arnd@arndb.de>
On Wed, 11 Jan 2017 14:39:44 +0100,
Arnd Bergmann wrote:
>
> gcc-7 caught what it considers a NULL pointer dereference:
>
> sound/pci/hda/patch_ca0132.c: In function 'dspio_scp.constprop':
> sound/pci/hda/patch_ca0132.c:1487:4: error: argument 1 null where non-null expected [-Werror=nonnull]
>
> This is plausible from looking at the function, as we compare 'reply'
> to NULL earlier in it. I have not tried to analyze if there are constraints
> that make it impossible to hit the bug, but adding another NULL check in
> the end kills the warning and makes the function more robust.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied, thanks.
Takashi
prev parent reply other threads:[~2017-01-11 16:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 13:39 Arnd Bergmann
2017-01-11 16:26 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h37gpy33x.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®