mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Colin King" <colin.king@canonical.com>
Cc: <alsa-devel@alsa-project.org>,
	"Vinod Koul" <vinod.koul@intel.com>, <trivial@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: compress: fix some missing and misplaced \n in messages
Date: Fri, 16 Sep 2016 19:25:07 +0200	[thread overview]
Message-ID: <s5h37kzoiz0.wl-tiwai@suse.de> (raw)
In-Reply-To: <20160916164641.11805-1-colin.king@canonical.com>

On Fri, 16 Sep 2016 18:46:41 +0200,
Colin King wrote:
> 
> From: Colin Ian King <colin.king@canonical.com>
> 
> Fix a missing \n in a pr_debug message and move the \n to the end
> of a pr_err message.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.


Takashi

> ---
>  sound/core/compress_offload.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
> index 583d407..fec1dfd 100644
> --- a/sound/core/compress_offload.c
> +++ b/sound/core/compress_offload.c
> @@ -780,7 +780,7 @@ static int snd_compress_wait_for_drain(struct snd_compr_stream *stream)
>  	ret = wait_event_interruptible(stream->runtime->sleep,
>  			(stream->runtime->state != SNDRV_PCM_STATE_DRAINING));
>  	if (ret == -ERESTARTSYS)
> -		pr_debug("wait aborted by a signal");
> +		pr_debug("wait aborted by a signal\n");
>  	else if (ret)
>  		pr_debug("wait for drain failed with %d\n", ret);
>  
> @@ -962,7 +962,7 @@ static int snd_compress_dev_register(struct snd_device *device)
>  				  compr->card, compr->device,
>  				  &snd_compr_file_ops, compr, &compr->dev);
>  	if (ret < 0) {
> -		pr_err("snd_register_device failed\n %d", ret);
> +		pr_err("snd_register_device failed %d\n", ret);
>  		return ret;
>  	}
>  	return ret;
> -- 
> 2.9.3
> 
> 

      reply	other threads:[~2016-09-16 17:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16 16:46 Colin King
2016-09-16 17:25 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h37kzoiz0.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=colin.king@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=trivial@kernel.org \
    --cc=vinod.koul@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®