From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965499AbaKNNSg (ORCPT ); Fri, 14 Nov 2014 08:18:36 -0500 Received: from cantor2.suse.de ([195.135.220.15]:32905 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964865AbaKNNSd (ORCPT ); Fri, 14 Nov 2014 08:18:33 -0500 Date: Fri, 14 Nov 2014 14:18:31 +0100 Message-ID: From: Takashi Iwai To: Sudip Mukherjee Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] ALSA: ice1712: consider error value In-Reply-To: <1415968941-14181-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1415968941-14181-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.4 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Fri, 14 Nov 2014 18:12:21 +0530, Sudip Mukherjee wrote: > > earlier we were ignoring the return value of snd_ak4114_create and > always returning 0. > now we are returning the actual status. revo_init is calling this > function, and revo_init is checking the return value. > > Signed-off-by: Sudip Mukherjee > --- > > change in v3: spec->ak4114 is now dereferenced if we dont get an > error value from snd_ak4114_create. > > change in v4: error value returned according to coding style. Applied but I had to fix your From address (two others, too). That doesn't match with your sign-off. Please fix your git config to have a proper author address as same as sign-off. thanks, Takashi > > sound/pci/ice1712/revo.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c > index 1112ec1..1d81ae6 100644 > --- a/sound/pci/ice1712/revo.c > +++ b/sound/pci/ice1712/revo.c > @@ -494,11 +494,13 @@ static int ap192_ak4114_init(struct snd_ice1712 *ice) > ap192_ak4114_write, > ak4114_init_vals, ak4114_init_txcsb, > ice, &spec->ak4114); > + if (err < 0) > + return err; > /* AK4114 in Revo cannot detect external rate correctly. > * No reason to stop capture stream due to incorrect checks */ > spec->ak4114->check_flags = AK4114_CHECK_NO_RATE; > > - return 0; /* error ignored; it's no fatal error */ > + return 0; > } > > static int revo_init(struct snd_ice1712 *ice) > -- > 1.8.1.2 >