From: Takashi Iwai <tiwai@suse.de>
To: Hans Wennborg <hans@hanshq.net>
Cc: clemens@ladisch.de, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH 19/19] alsa: riptide: fix %d confusingly prefixed with 0x in format strings
Date: Mon, 04 Aug 2014 13:19:41 +0200 [thread overview]
Message-ID: <s5h38dcwlgy.wl%tiwai@suse.de> (raw)
In-Reply-To: <1407111685-15351-1-git-send-email-hans@hanshq.net>
At Sun, 3 Aug 2014 17:21:25 -0700,
Hans Wennborg wrote:
>
> Signed-off-by: Hans Wennborg <hans@hanshq.net>
Applied after ripping out the superfluous fireworks changes.
Takashi
> ---
> sound/firewire/fireworks/fireworks_proc.c | 4 ++--
> sound/pci/riptide/riptide.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/firewire/fireworks/fireworks_proc.c b/sound/firewire/fireworks/fireworks_proc.c
> index 02bf394..23bb274 100644
> --- a/sound/firewire/fireworks/fireworks_proc.c
> +++ b/sound/firewire/fireworks/fireworks_proc.c
> @@ -64,7 +64,7 @@ proc_read_hwinfo(struct snd_info_entry *entry, struct snd_info_buffer *buffer)
> hwinfo->phys_in_grp_count);
> for (i = 0; i < hwinfo->phys_in_grp_count; i++) {
> snd_iprintf(buffer,
> - "phys in grp[0x%d]: type 0x%d, count 0x%x\n",
> + "phys in grp[0x%x]: type 0x%x, count 0x%x\n",
> i, hwinfo->phys_out_grps[i].type,
> hwinfo->phys_out_grps[i].count);
> }
> @@ -73,7 +73,7 @@ proc_read_hwinfo(struct snd_info_entry *entry, struct snd_info_buffer *buffer)
> hwinfo->phys_out_grp_count);
> for (i = 0; i < hwinfo->phys_out_grp_count; i++) {
> snd_iprintf(buffer,
> - "phys out grps[0x%d]: type 0x%d, count 0x%x\n",
> + "phys out grps[0x%x]: type 0x%x, count 0x%x\n",
> i, hwinfo->phys_out_grps[i].type,
> hwinfo->phys_out_grps[i].count);
> }
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index b4a8278..f0315c3 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -941,7 +941,7 @@ setmixer(struct cmdif *cif, short num, unsigned short rval, unsigned short lval)
> union cmdret rptr = CMDRET_ZERO;
> int i = 0;
>
> - snd_printdd("sent mixer %d: 0x%d 0x%d\n", num, rval, lval);
> + snd_printdd("sent mixer %d: 0x%x 0x%x\n", num, rval, lval);
> do {
> SEND_SDGV(cif, num, num, rval, lval);
> SEND_RDGV(cif, num, num, &rptr);
> @@ -1080,7 +1080,7 @@ getmixer(struct cmdif *cif, short num, unsigned short *rval,
> return -EIO;
> *rval = rptr.retwords[0];
> *lval = rptr.retwords[1];
> - snd_printdd("got mixer %d: 0x%d 0x%d\n", num, *rval, *lval);
> + snd_printdd("got mixer %d: 0x%x 0x%x\n", num, *rval, *lval);
> return 0;
> }
>
> --
> 2.0.0.526.g5318336
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
prev parent reply other threads:[~2014-08-04 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-04 0:21 Hans Wennborg
2014-08-04 7:20 ` Clemens Ladisch
2014-08-04 11:19 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h38dcwlgy.wl%tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=hans@hanshq.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®