From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752777AbaFAQXg (ORCPT ); Sun, 1 Jun 2014 12:23:36 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58122 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752466AbaFAQXf (ORCPT ); Sun, 1 Jun 2014 12:23:35 -0400 Date: Sun, 01 Jun 2014 18:23:31 +0200 Message-ID: From: Takashi Iwai To: Rickard Strandqvist Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: pci: ice1712: wm8766.c: Cleaning up uninitialized variables In-Reply-To: <1401631371-21145-1-git-send-email-rickard_strandqvist@spectrumdigital.se> References: <1401631371-21145-1-git-send-email-rickard_strandqvist@spectrumdigital.se> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Sun, 1 Jun 2014 16:02:51 +0200, Rickard Strandqvist wrote: > > There is a risk that the variable will be used without being initialized. > > This was largely found by using a static code analysis program called cppcheck. It won't happen in reality. And, initializing to some random values isn't always received good. You can use uninitialized_var() in such a case, too. Takashi > > Signed-off-by: Rickard Strandqvist > --- > sound/pci/ice1712/wm8766.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/ice1712/wm8766.c b/sound/pci/ice1712/wm8766.c > index 21b373b..788a31c 100644 > --- a/sound/pci/ice1712/wm8766.c > +++ b/sound/pci/ice1712/wm8766.c > @@ -237,7 +237,7 @@ static int snd_wm8766_ctl_get(struct snd_kcontrol *kcontrol, > { > struct snd_wm8766 *wm = snd_kcontrol_chip(kcontrol); > int n = kcontrol->private_value; > - u16 val1, val2; > + u16 val1 = 0, val2 = 0; > > if (wm->ctl[n].get) > wm->ctl[n].get(wm, &val1, &val2); > -- > 1.7.10.4 >