From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755287AbaE3IXs (ORCPT ); Fri, 30 May 2014 04:23:48 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58737 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752545AbaE3IXq (ORCPT ); Fri, 30 May 2014 04:23:46 -0400 Date: Fri, 30 May 2014 10:23:44 +0200 Message-ID: From: Takashi Iwai To: Paul Bolle Cc: Jaroslav Kysela , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sound: remove checks for CONFIG_SND_DEBUG_ROM In-Reply-To: <1401382705.25908.9.camel@x220> References: <1401382705.25908.9.camel@x220> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org At Thu, 29 May 2014 18:58:25 +0200, Paul Bolle wrote: > > Checks for CONFIG_SND_DEBUG_ROM were added in v2.5.5 but a Kconfig > symbol SND_DEBUG_ROM was never added. These checks have always > evaluated to false. Remove them and the printk()s they hide. > > Signed-off-by: Paul Bolle > --- > Untested. > > Perhaps one is expected to define this debugging macro by hand, somehow. > In that case it would be nice to drop the CONFIG_ prefix. Yeah, but I guess a developer can add such printk anyway easily, so let's clean up the code at first. So, I took your patch now as is. thanks, Takashi > > sound/isa/gus/interwave.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/sound/isa/gus/interwave.c b/sound/isa/gus/interwave.c > index 5abbbe477d16..ad55e5cb8e94 100644 > --- a/sound/isa/gus/interwave.c > +++ b/sound/isa/gus/interwave.c > @@ -442,17 +442,11 @@ static void snd_interwave_detect_memory(struct snd_gus_card *gus) > for (bank_pos = 0; bank_pos < 16L * 1024L * 1024L; bank_pos += 4L * 1024L * 1024L) { > for (i = 0; i < 8; ++i) > iwave[i] = snd_gf1_peek(gus, bank_pos + i); > -#ifdef CONFIG_SND_DEBUG_ROM > - printk(KERN_DEBUG "ROM at 0x%06x = %8phC\n", bank_pos, iwave); > -#endif > if (strncmp(iwave, "INTRWAVE", 8)) > continue; /* first check */ > csum = 0; > for (i = 0; i < sizeof(struct rom_hdr); i++) > csum += snd_gf1_peek(gus, bank_pos + i); > -#ifdef CONFIG_SND_DEBUG_ROM > - printk(KERN_DEBUG "ROM checksum = 0x%x (computed)\n", csum); > -#endif > if (csum != 0) > continue; /* not valid rom */ > gus->gf1.rom_banks++; > -- > 1.9.3 >