From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753242Ab3KDIuH (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 Nov 2013 03:50:07 -0500
Received: from cantor2.suse.de ([195.135.220.15]:36760 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752948Ab3KDIuF (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 Nov 2013 03:50:05 -0500
Date: Mon, 04 Nov 2013 09:49:58 +0100
Message-ID: <s5h38ncsg95.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Nicolin Chen <b42378@freescale.com>
Cc: <akpm@linux-foundation.org>, <joe@perches.com>, <nsekhar@ti.com>,
        <khilman@deeprootsystems.com>, <linux@arm.linux.org.uk>,
        <dan.j.williams@intel.com>, <vinod.koul@intel.com>,
        <m.chehab@samsung.com>, <hjk@hansjkoch.de>,
        <gregkh@linuxfoundation.org>, <perex@perex.cz>, <lgirdwood@gmail.com>,
        <broonie@kernel.org>, <rmk+kernel@arm.linux.org.uk>,
        <eric.y.miao@gmail.com>, <haojian.zhuang@gmail.com>,
        <linux-kernel@vger.kernel.org>,
        <davinci-linux-open-source@linux.davincidsp.com>,
        <linux-arm-kernel@lists.infradead.org>, <dmaengine@vger.kernel.org>,
        <linux-media@vger.kernel.org>, <alsa-devel@alsa-project.org>
Subject: Re: [PATCH][RESEND 6/8] ALSA: memalloc: use gen_pool_dma_alloc() to allocate iram buffer
In-Reply-To: <db9e59951cdcf55b4903c0358ebe220e58155bc1.1383306365.git.b42378@freescale.com>
References: <cover.1383306365.git.b42378@freescale.com>
	<db9e59951cdcf55b4903c0358ebe220e58155bc1.1383306365.git.b42378@freescale.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Fri, 1 Nov 2013 19:48:19 +0800,
Nicolin Chen wrote:
> 
> Since gen_pool_dma_alloc() is introduced, we implement it to simplify code.
> 
> Signed-off-by: Nicolin Chen <b42378@freescale.com>

Acked-by: Takashi Iwai <tiwai@suse.de>


> ---
>  sound/core/memalloc.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/sound/core/memalloc.c b/sound/core/memalloc.c
> index 9d93f02..5e1c7bc 100644
> --- a/sound/core/memalloc.c
> +++ b/sound/core/memalloc.c
> @@ -184,11 +184,7 @@ static void snd_malloc_dev_iram(struct snd_dma_buffer *dmab, size_t size)
>  	/* Assign the pool into private_data field */
>  	dmab->private_data = pool;
>  
> -	dmab->area = (void *)gen_pool_alloc(pool, size);
> -	if (!dmab->area)
> -		return;
> -
> -	dmab->addr = gen_pool_virt_to_phys(pool, (unsigned long)dmab->area);
> +	dmab->area = gen_pool_dma_alloc(pool, size, &dmab->addr);
>  }
>  
>  /**
> -- 
> 1.8.4
> 
>