Re: 2.6.38.4 broke my audio

[Takashi Iwai <tiwai@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 3568 bytes --]

At Wed, 27 Apr 2011 08:15:28 +0700,
Emmanuel Benisty wrote:
> 
> [1  <text/plain; UTF-8 (quoted-printable)>]
> On Tue, Apr 26, 2011 at 7:49 PM, Takashi Iwai <tiwai@suse.de> wrote:
> > At Tue, 26 Apr 2011 08:42:59 +0700,
> > Emmanuel Benisty wrote:
> >>
> >> On Tue, Apr 26, 2011 at 3:25 AM, Takashi Iwai <tiwai@suse.de> wrote:
> >> > At Mon, 25 Apr 2011 10:34:09 -0700,
> >> > Greg KH wrote:
> >> >>
> >> >> On Mon, Apr 25, 2011 at 11:25:29AM +0200, Takashi Iwai wrote:
> >> >> > At Sun, 24 Apr 2011 17:01:26 -0700,
> >> >> > Greg KH wrote:
> >> >> > >
> >> >> > > On Sun, Apr 24, 2011 at 11:30:37AM +0100, Andrew Clayton wrote:
> >> >> > > > Hi guys.
> >> >> > > >
> >> >> > > > Just upgraded to .4 from .3 and found my audio was _really_ quiet. All
> >> >> > > > the mixers looked sane.
> >> >> > > >
> >> >> > > > A quick check of the changelog and a revert of:
> >> >> > > >
> >> >> > > > commit 58541cc27531727f7120683a7cb123ee3ada4bd4
> >> >> > > > Author: Takashi Iwai <tiwai@suse.de>
> >> >> > > > Date:   Mon Mar 28 12:05:31 2011 +0200
> >> >> > > >
> >> >> > > >     ALSA: hda - Fix pin-config of Gigabyte mobo
> >> >> > > >
> >> >> > > >     commit c6b358748e19ce7e230b0926ac42696bc485a562 upstream.
> >> >> > > >
> >> >> > > >     Use pin-fix instead of the static quirk for Gigabyte mobos 1458:a002.
> >> >> > > >
> >> >> > > >     Bugzilla: https://bugzilla.novell.com/show_bug.cgi?id=677256
> >> >> > > >     Signed-off-by: Takashi Iwai <tiwai@suse.de>
> >> >> > > >     Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> >> >> > > >
> >> >> > > > made it normal again.
> >> >> > >
> >> >> > > Takashi, do you have a fix for this, or should I revert this from the
> >> >> > > .38 stable tree?  It looks like we now have 2 reports of this problem.
> >> >> >
> >> >> > If we need to revert, I'll do it in the upstream first, as it must hit
> >> >> > to 2.6.39, too.
> >> >>
> >> >> True.
> >> >>
> >> >> > But let me check this breakage first.  I'll take a look at it more
> >> >> > deeply tomorrow.
> >> >>
> >> >> Ok, that sounds good.
> >> >
> >> > Thanks.
> >> >
> >> > Andrew, could you give alsa-info.sh outputs on your machine?
> >> > Preferably, the outputs both before and after the kernel update would
> >> > be really helpful.
> >>
> >> In case it might help, mine are attached too.
> >
> > Thanks.  But the output after update (alsa-info.txt.bad) looks weird.
> > It contains unexpected pin-update for NID 0x15 (found in
> > /sys/class/sound/hwC0D0/driver_pin_configs), and thus the mixer
> > elements created don't match with the results on HD-audio emulator.
> >
> > Could you double-check whether you have no modification over 2.6.38.4
> > driver?
> 
> Hi Takashi,
> 
> To double check, I have rebuilt .3 and .4 straight from kernel.org
> sources with the same config (which I attached, just in case).
> alsa-info.sh outputs are attached.

Thanks.  The bad output still shows the strange pin-config for NID
0x15 while it's not found in the good output.

Could you check the following?

1. Set model=auto option to snd-hda-intel module and boot 2.6.38.3.
   Get alsa-info.sh output.

2. Apply fix1.diff patch below to 2.6.38.4, and boot, get alsa-info.sh
   again.

3. Reviert fix1.diff, and apply fix2.diff to 2.6.38.4.  The same
   procedure.

The point to be checked is the widget 0x15.  In a good case, it should
have the pin config such as:
  Pin Default 0x411111f0: [N/A] Speaker at Ext Rear

In a bad case, the driver modifies this by some reason to 
  Pin Default 0x99130112: [Fixed] Speaker at Int ATAPI


Takashi

[-- Attachment #2: fix1.diff --]
[-- Type: application/octet-stream, Size: 837 bytes --]

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index da7cdca..02feb02 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -19574,7 +19574,7 @@ static struct snd_pci_quirk alc662_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1025, 0x0308, "Acer Aspire 8942G", ALC662_FIXUP_ASPIRE),
 	SND_PCI_QUIRK(0x1025, 0x038b, "Acer Aspire 8943G", ALC662_FIXUP_ASPIRE),
 	SND_PCI_QUIRK(0x144d, 0xc051, "Samsung R720", ALC662_FIXUP_IDEAPAD),
-	SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte", ALC662_FIXUP_GIGABYTE),
+	// SND_PCI_QUIRK(0x1458, 0xa002, "Gigabyte", ALC662_FIXUP_GIGABYTE),
 	SND_PCI_QUIRK(0x17aa, 0x38af, "Lenovo Ideapad Y550P", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Ideapad Y550", ALC662_FIXUP_IDEAPAD),
 	SND_PCI_QUIRK(0x1b35, 0x2206, "CZC P10T", ALC662_FIXUP_CZC_P10T),

[-- Attachment #3: fix2.diff --]
[-- Type: application/octet-stream, Size: 391 bytes --]

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index da7cdca..fd34f7b 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -19566,7 +19566,8 @@ static const struct alc_fixup alc662_fixups[] = {
 		.v.pins = (const struct alc_pincfg[]) {
 			{ 0x14, 0x1114410 }, /* set as speaker */
 			{ }
-		}
+		},
+		.chained = false,
 	},
 };