From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756143Ab0CJJuw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 10 Mar 2010 04:50:52 -0500
Received: from cantor.suse.de ([195.135.220.2]:41146 "EHLO mx1.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755001Ab0CJJut (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 10 Mar 2010 04:50:49 -0500
Date: Wed, 10 Mar 2010 10:50:47 +0100
Message-ID: <s5h3a08sdxk.wl%tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Ralf Gerbig <rge@quengel.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-kernel@vger.kernel.org
Subject: Re: Sound MSI fallout on a Asus mobo NVIDIA MCP55
In-Reply-To: <87ocixi6gg.fsf@gerlin1.hsp-law.de>
References: <87hboq32lr.fsf@gerlin1.hsp-law.de>
	<s5hfx49s8rq.wl%tiwai@suse.de>
	<87ocixi6gg.fsf@gerlin1.hsp-law.de>
User-Agent: Wanderlust/2.15.6 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.7 Emacs/23.1
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

At Tue, 09 Mar 2010 21:30:07 +0100,
Ralf Gerbig wrote:
> 
> Moins,
> 
> * Takashi Iwai writes:
> 
> > Applied now.
> > But, at the next time, please submit a patch that can be applied directly.
> > See Documentation/SubmittingPatches for details.
> 
> >> --- a/sound/pci/hda/hda_intel.c
> >> +++ b/sound/pci/hda/hda_intel.c
> >> @@ -2351,6 +2351,7 @@
> >> static struct snd_pci_quirk msi_black_list[] __devinitdata = {
> >> SND_PCI_QUIRK(0x1043, 0x81f2, "ASUS", 0), /* Athlon64 X2 + nvidia */
> >> SND_PCI_QUIRK(0x1043, 0x81f6, "ASUS", 0), /* nvidia */
> >> +	SND_PCI_QUIRK(0x1043, 0x822d, "ASUS", 0), /* Athlon64 X2 + nvidia MCP55*/
> >> {}
> >> };
> >> 
> >> if you need it: Signed-off-by: Ralf Gerbig <rge@quengel.org>
> >> 
> >> Ralf
> >> 
> 
> oops, sorry but I'm not a developer. I did apply this to my tree and
> it worked - what went wrong?

[dropped stable list]

It's just about the patch file format.  The change you made is fine.

If the patch is posted in a format described in SubmittingPatches, we
can apply it directly with git-am without modifying much.  Otherwise,
manual editing is needed, and this might introduce unnecessary
cut&paste errors.


thanks,

Takashi